# Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage 3 messages from 2015-03-06 to 2015-03-06. Participants: Akshay Aurora, Max Kirillov. Thread: https://gitlist.dev/t/38719 ## Akshay Aurora, 2015-03-06 05:08 Subject: Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage Message-ID: URL: https://gitlist.dev/e/CAPGnZZ%3DWJcd%3DGWkMqq93RXpJz8jvqnaZctcF2Tni3qkO2vhSOw%40mail.gmail.com In-Reply-To: <1425582632-28273-1-git-send-email-akshayaurora@yahoo.com> ``` Not sure, why this mail is not showing on Gmane. I used git to send the email, and tested it by sending the patch to myself before sending it to the list. On Fri, Mar 6, 2015 at 12:40 AM, Akshay Aurora wrote: > Signed-off-by: Akshay Aurora > --- > This is my first patch for a GSoC Microproject, would be great to have your feedback. > > revision.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/revision.c b/revision.c > index bd027bc..d578652 100644 > --- a/revision.c > +++ b/revision.c > @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s > */ > if (revs->reverse && revs->graph) > die("cannot combine --reverse with --graph"); > - > + if (revs->no_walk && revs->graph) > + die("cannot combine --no-walk with --graph"); > if (revs->reflog_info && revs->graph) > die("cannot combine --walk-reflogs with --graph"); > if (!revs->reflog_info && revs->grep_filter.use_reflog_filter) > -- > 2.3.1 > -- AA ``` ## Max Kirillov, 2015-03-06 08:37 Subject: Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage Message-ID: URL: https://gitlist.dev/e/CAF7_NFRKetzHEB5tfENA%3DA-wwStwJG7yCbUKYLZos%2B0WSekeig%40mail.gmail.com In-Reply-To: ``` On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora wrote: > Not sure, why this mail is not showing on Gmane. > I used git to send the email, and tested it by sending the patch to > myself before sending it to the list. Gmail knows: "Why is this message in Spam? It has a from address in yahoo.com but has failed yahoo.com's required tests for authentication. Learn more" Probably filtering settings are less strict. I guess you should use authenticated SMTP thought your email hoster, yahoo here in git-send-email (something like --smtp-server and --smtp-user options, it will ask for password interactively) to avoid it. ``` ## Akshay Aurora, 2015-03-06 12:11 Subject: Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage Message-ID: URL: https://gitlist.dev/e/CAPGnZZkxTMDqfJEogxy2hGJv033t_ehU_LucChpVqqKWRLxR%3Dw%40mail.gmail.com In-Reply-To: ``` Thanks for replying. I'll try sending the patch directly using gmail smtp servers next time. Going by the description of the options. I doubt --graph and --no-walk would ever make sense together. So my patch forbids these two options together for all commands calling setup_revisions(). And isn't specific to just `git log`. Also, seeing other patches to this microproject. I think I should also update Documentation for rev-list-options. Do you think we need a test for this? Would a test using only `git log` be suffice? On Fri, Mar 6, 2015 at 2:07 PM, Max Kirillov wrote: > On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora wrote: >> Not sure, why this mail is not showing on Gmane. >> I used git to send the email, and tested it by sending the patch to >> myself before sending it to the list. > > Gmail knows: "Why is this message in Spam? It has a from address in > yahoo.com but has failed yahoo.com's required tests for > authentication. Learn more" Probably filtering settings are less > strict. > > I guess you should use authenticated SMTP thought your email hoster, > yahoo here in git-send-email (something like --smtp-server and > --smtp-user options, it will ask for password interactively) to avoid > it. -- AA ```