Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage

From: Akshay Aurora <akshayaurora@yahoo.com>
Date: Mar 6, 2015, 12:11 UTC
Message-ID: <CAPGnZZkxTMDqfJEogxy2hGJv033t_ehU_LucChpVqqKWRLxR=w@mail.gmail.com>
In-Reply-To: <CAF7_NFRKetzHEB5tfENA=A-wwStwJG7yCbUKYLZos+0WSekeig@mail.gmail.com>

Thanks for replying. I'll try sending the patch directly using gmail smtp servers next time.

Going by the description of the options. I doubt --graph and --no-walk would ever make sense together. So my patch forbids these two options together for all commands calling setup_revisions(). And isn't specific to just `git log`.

Also, seeing other patches to this microproject. I think I should also update Documentation for rev-list-options.

Do you think we need a test for this? Would a test using only `git log` be suffice?

On Fri, Mar 6, 2015 at 2:07 PM, Max Kirillov <max@max630.net> wrote:

Show 14 quoted lines

> On Fri, Mar 6, 2015 at 7:08 AM, Akshay Aurora <akshayaurora@yahoo.com> wrote:
>> Not sure, why this mail is not showing on Gmane.
>> I used git to send the email, and tested it by sending the patch to
>> myself before sending it to the list.
>
> Gmail knows: "Why is this message in Spam? It has a from address in
> yahoo.com but has failed yahoo.com's required tests for
> authentication.  Learn more" Probably filtering settings are less
> strict.
>
> I guess you should use authenticated SMTP thought your email hoster,
> yahoo here in git-send-email (something like --smtp-server and
> --smtp-user options, it will ask for password interactively) to avoid
> it.

-- 
AA