threads / patch / 38426

patchgitk: Remove tcl-format flag from a message that shouldn't have it

Subject: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

## tl;dr

7 messages between Jan 22, 2015 and Mar 22, 2015. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Alex Henrie· Jan 22, 2015, 08:19 UTC · lore

xgettext sees "% o" and interprets it as a placeholder for an octal number preceded by a space. However, in this case it's not actually a placeholder, and most translations will replace the "% o" sequence with something else. Removing the tcl-format flag from this string prevents tools like Poedit from freaking out when "% o" doesn't appear in the translated string.

The corrected flag will appear in each translation's po file the next time the translation is updated with `make update-po`.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 gitk-git/gitk | 1 +
 1 file changed, 1 insertion(+)
Show changes to gitk-git/gitk +1 −0
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 78358a7..dfd458d 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} {
     ${NS}::label $page.maxwidthl -text [mc "Maximum graph width (lines)"]
     spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth
     grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w
+                                         #xgettext:no-tcl-format
     ${NS}::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"]
     spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
     grid x $page.maxpctl $page.maxpct -sticky w

-- 
2.2.2
Alex Henrie· Feb 9, 2015, 21:36 UTC · re: Alex Henrie · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

Hi,

This is just a friendly reminder that this patch has been sitting in the mailing list archives for a couple of weeks, and it has not yet been accepted or commented on.

-Alex
Junio C Hamano· Feb 9, 2015, 21:55 UTC · re: Alex Henrie · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

Alex Henrie <alexhenrie24@gmail.com> writes:
> This is just a friendly reminder that this patch has been sitting in
> the mailing list archives for a couple of weeks, and it has not yet
> been accepted or commented on.

I think that is because the message was not sent to the right people, and also because the patch was made against a wrong project ;-).

I'll forward it to the gitk maintainer after digging it out of the archive and tweaking it. Thanks.

Paul, comments?
-- >8 --
From: Alex Henrie <alexhenrie24@gmail.com>
Date: Thu, 22 Jan 2015 01:19:39 -0700
Subject: gitk: Remove tcl-format flag from a message that shouldn't have it

xgettext sees "% o" and interprets it as a placeholder for an octal number preceded by a space. However, in this case it's not actually a placeholder, and most translations will replace the "% o" sequence with something else. Removing the tcl-format flag from this string prevents tools like Poedit from freaking out when "% o" doesn't appear in the translated string.

The corrected flag will appear in each translation's po file the next time the translation is updated with `make update-po`.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 gitk | 1 +
 1 file changed, 1 insertion(+)
Show changes to gitk +1 −0
diff --git a/gitk b/gitk
index 78358a7..dfd458d 100755
--- a/gitk
+++ b/gitk
@@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} {
     ${NS}::label $page.maxwidthl -text [mc "Maximum graph width (lines)"]
     spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth
     grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w
+                                         #xgettext:no-tcl-format
     ${NS}::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"]
     spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
     grid x $page.maxpctl $page.maxpct -sticky w

-- 
2.2.2
Alex Henrie· Feb 16, 2015, 23:27 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

2015-02-09 14:55 GMT-07:00 Junio C Hamano <gitster@pobox.com>:
Show 15 quoted lines
>
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > This is just a friendly reminder that this patch has been sitting in
> > the mailing list archives for a couple of weeks, and it has not yet
> > been accepted or commented on.
>
> I think that is because the message was not sent to the right
> people, and also because the patch was made against a wrong project
> ;-).
>
> I'll forward it to the gitk maintainer after digging it out of the
> archive and tweaking it.  Thanks.
>
> Paul, comments?

Another week and still no comments on either this patch or the gitk Catalan translation patch. Is Paul Mackerras still actively involved in the project?

-Alex
Alex Henrie· Feb 23, 2015, 22:30 UTC · re: Alex Henrie · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

2015-02-16 16:27 GMT-07:00 Alex Henrie <alexhenrie24@gmail.com>:
Show 22 quoted lines
> 2015-02-09 14:55 GMT-07:00 Junio C Hamano <gitster@pobox.com>:
>>
>> Alex Henrie <alexhenrie24@gmail.com> writes:
>>
>> > This is just a friendly reminder that this patch has been sitting in
>> > the mailing list archives for a couple of weeks, and it has not yet
>> > been accepted or commented on.
>>
>> I think that is because the message was not sent to the right
>> people, and also because the patch was made against a wrong project
>> ;-).
>>
>> I'll forward it to the gitk maintainer after digging it out of the
>> archive and tweaking it.  Thanks.
>>
>> Paul, comments?
>
> Another week and still no comments on either this patch or the gitk
> Catalan translation patch. Is Paul Mackerras still actively involved
> in the project?
>
> -Alex

Another week and still no response. If Paul is no longer maintaining gitk, another maintainer should be appointed.

-Alex
Alex Henrie· Mar 10, 2015, 18:53 UTC · re: Alex Henrie · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

2015-02-23 15:30 GMT-07:00 Alex Henrie <alexhenrie24@gmail.com>:
Show 28 quoted lines
> 2015-02-16 16:27 GMT-07:00 Alex Henrie <alexhenrie24@gmail.com>:
>> 2015-02-09 14:55 GMT-07:00 Junio C Hamano <gitster@pobox.com>:
>>>
>>> Alex Henrie <alexhenrie24@gmail.com> writes:
>>>
>>> > This is just a friendly reminder that this patch has been sitting in
>>> > the mailing list archives for a couple of weeks, and it has not yet
>>> > been accepted or commented on.
>>>
>>> I think that is because the message was not sent to the right
>>> people, and also because the patch was made against a wrong project
>>> ;-).
>>>
>>> I'll forward it to the gitk maintainer after digging it out of the
>>> archive and tweaking it.  Thanks.
>>>
>>> Paul, comments?
>>
>> Another week and still no comments on either this patch or the gitk
>> Catalan translation patch. Is Paul Mackerras still actively involved
>> in the project?
>>
>> -Alex
>
> Another week and still no response. If Paul is no longer maintaining
> gitk, another maintainer should be appointed.
>
> -Alex

I am unsubscribing from the Git mailing list. As far as I can tell, the gitk project does not accept patches, not even translations into new languages. If this policy ever changes, please email me directly.

-Alex
Paul Mackerras· Mar 22, 2015, 03:40 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote:
Show 31 quoted lines
> Alex Henrie <alexhenrie24@gmail.com> writes:
> 
> > This is just a friendly reminder that this patch has been sitting in
> > the mailing list archives for a couple of weeks, and it has not yet
> > been accepted or commented on.
> 
> I think that is because the message was not sent to the right
> people, and also because the patch was made against a wrong project
> ;-).
> 
> I'll forward it to the gitk maintainer after digging it out of the
> archive and tweaking it.  Thanks.
> 
> Paul, comments?
> 
> -- >8 --
> From: Alex Henrie <alexhenrie24@gmail.com>
> Date: Thu, 22 Jan 2015 01:19:39 -0700
> Subject: gitk: Remove tcl-format flag from a message that shouldn't have it
> 
> xgettext sees "% o" and interprets it as a placeholder for an octal
> number preceded by a space. However, in this case it's not actually a
> placeholder, and most translations will replace the "% o" sequence with
> something else. Removing the tcl-format flag from this string prevents
> tools like Poedit from freaking out when "% o" doesn't appear in the
> translated string.
> 
> The corrected flag will appear in each translation's po file the next time
> the translation is updated with `make update-po`.
> 
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Thanks, applied.
Paul.

← back to recent threads