# [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it 7 messages from 2015-01-22 to 2015-03-22. Participants: Alex Henrie, Junio C Hamano, Paul Mackerras. Thread: https://gitlist.dev/t/38426 ## Alex Henrie, 2015-01-22 08:19 Subject: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: <1421914779-30865-1-git-send-email-alexhenrie24@gmail.com> URL: https://gitlist.dev/e/1421914779-30865-1-git-send-email-alexhenrie24%40gmail.com ``` xgettext sees "% o" and interprets it as a placeholder for an octal number preceded by a space. However, in this case it's not actually a placeholder, and most translations will replace the "% o" sequence with something else. Removing the tcl-format flag from this string prevents tools like Poedit from freaking out when "% o" doesn't appear in the translated string. The corrected flag will appear in each translation's po file the next time the translation is updated with `make update-po`. Signed-off-by: Alex Henrie --- gitk-git/gitk | 1 + 1 file changed, 1 insertion(+) diff --git a/gitk-git/gitk b/gitk-git/gitk index 78358a7..dfd458d 100755 --- a/gitk-git/gitk +++ b/gitk-git/gitk @@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} { ${NS}::label $page.maxwidthl -text [mc "Maximum graph width (lines)"] spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w + #xgettext:no-tcl-format ${NS}::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"] spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct grid x $page.maxpctl $page.maxpct -sticky w -- 2.2.2 ``` ## Alex Henrie, 2015-02-09 21:36 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: URL: https://gitlist.dev/e/CAMMLpeTvtzPuiQJVxAx-Ja4JsoUxih5azMaN7_RcLvajny6A6g%40mail.gmail.com In-Reply-To: <1421914779-30865-1-git-send-email-alexhenrie24@gmail.com> ``` Hi, This is just a friendly reminder that this patch has been sitting in the mailing list archives for a couple of weeks, and it has not yet been accepted or commented on. -Alex ``` ## Junio C Hamano, 2015-02-09 21:55 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: URL: https://gitlist.dev/e/xmqqlhk6agxg.fsf%40gitster.dls.corp.google.com In-Reply-To: ``` Alex Henrie writes: > This is just a friendly reminder that this patch has been sitting in > the mailing list archives for a couple of weeks, and it has not yet > been accepted or commented on. I think that is because the message was not sent to the right people, and also because the patch was made against a wrong project ;-). I'll forward it to the gitk maintainer after digging it out of the archive and tweaking it. Thanks. Paul, comments? -- >8 -- From: Alex Henrie Date: Thu, 22 Jan 2015 01:19:39 -0700 Subject: gitk: Remove tcl-format flag from a message that shouldn't have it xgettext sees "% o" and interprets it as a placeholder for an octal number preceded by a space. However, in this case it's not actually a placeholder, and most translations will replace the "% o" sequence with something else. Removing the tcl-format flag from this string prevents tools like Poedit from freaking out when "% o" doesn't appear in the translated string. The corrected flag will appear in each translation's po file the next time the translation is updated with `make update-po`. Signed-off-by: Alex Henrie --- gitk | 1 + 1 file changed, 1 insertion(+) diff --git a/gitk b/gitk index 78358a7..dfd458d 100755 --- a/gitk +++ b/gitk @@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} { ${NS}::label $page.maxwidthl -text [mc "Maximum graph width (lines)"] spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w + #xgettext:no-tcl-format ${NS}::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"] spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct grid x $page.maxpctl $page.maxpct -sticky w -- 2.2.2 ``` ## Alex Henrie, 2015-02-16 23:27 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: URL: https://gitlist.dev/e/CAMMLpeR6TkZxFQBVJukC3KgXM-cJkRY31m8OthHxMkaZzLqGjg%40mail.gmail.com In-Reply-To: ``` 2015-02-09 14:55 GMT-07:00 Junio C Hamano : > > Alex Henrie writes: > > > This is just a friendly reminder that this patch has been sitting in > > the mailing list archives for a couple of weeks, and it has not yet > > been accepted or commented on. > > I think that is because the message was not sent to the right > people, and also because the patch was made against a wrong project > ;-). > > I'll forward it to the gitk maintainer after digging it out of the > archive and tweaking it. Thanks. > > Paul, comments? Another week and still no comments on either this patch or the gitk Catalan translation patch. Is Paul Mackerras still actively involved in the project? -Alex ``` ## Alex Henrie, 2015-02-23 22:30 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: URL: https://gitlist.dev/e/CAMMLpeQ0fyNm1pdF6iDBzh8q__g6H8Obgwg3mD680CydmCwfVw%40mail.gmail.com In-Reply-To: ``` 2015-02-16 16:27 GMT-07:00 Alex Henrie : > 2015-02-09 14:55 GMT-07:00 Junio C Hamano : >> >> Alex Henrie writes: >> >> > This is just a friendly reminder that this patch has been sitting in >> > the mailing list archives for a couple of weeks, and it has not yet >> > been accepted or commented on. >> >> I think that is because the message was not sent to the right >> people, and also because the patch was made against a wrong project >> ;-). >> >> I'll forward it to the gitk maintainer after digging it out of the >> archive and tweaking it. Thanks. >> >> Paul, comments? > > Another week and still no comments on either this patch or the gitk > Catalan translation patch. Is Paul Mackerras still actively involved > in the project? > > -Alex Another week and still no response. If Paul is no longer maintaining gitk, another maintainer should be appointed. -Alex ``` ## Alex Henrie, 2015-03-10 18:53 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: URL: https://gitlist.dev/e/CAMMLpeQWTzAsWwX2rsVhGLz4ZMcEsZw%3DauGeUeYow-P2kCM3Sg%40mail.gmail.com In-Reply-To: ``` 2015-02-23 15:30 GMT-07:00 Alex Henrie : > 2015-02-16 16:27 GMT-07:00 Alex Henrie : >> 2015-02-09 14:55 GMT-07:00 Junio C Hamano : >>> >>> Alex Henrie writes: >>> >>> > This is just a friendly reminder that this patch has been sitting in >>> > the mailing list archives for a couple of weeks, and it has not yet >>> > been accepted or commented on. >>> >>> I think that is because the message was not sent to the right >>> people, and also because the patch was made against a wrong project >>> ;-). >>> >>> I'll forward it to the gitk maintainer after digging it out of the >>> archive and tweaking it. Thanks. >>> >>> Paul, comments? >> >> Another week and still no comments on either this patch or the gitk >> Catalan translation patch. Is Paul Mackerras still actively involved >> in the project? >> >> -Alex > > Another week and still no response. If Paul is no longer maintaining > gitk, another maintainer should be appointed. > > -Alex I am unsubscribing from the Git mailing list. As far as I can tell, the gitk project does not accept patches, not even translations into new languages. If this policy ever changes, please email me directly. -Alex ``` ## Paul Mackerras, 2015-03-22 03:40 Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Message-ID: <20150322034012.GD14271@iris.ozlabs.ibm.com> URL: https://gitlist.dev/e/20150322034012.GD14271%40iris.ozlabs.ibm.com In-Reply-To: ``` On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote: > Alex Henrie writes: > > > This is just a friendly reminder that this patch has been sitting in > > the mailing list archives for a couple of weeks, and it has not yet > > been accepted or commented on. > > I think that is because the message was not sent to the right > people, and also because the patch was made against a wrong project > ;-). > > I'll forward it to the gitk maintainer after digging it out of the > archive and tweaking it. Thanks. > > Paul, comments? > > -- >8 -- > From: Alex Henrie > Date: Thu, 22 Jan 2015 01:19:39 -0700 > Subject: gitk: Remove tcl-format flag from a message that shouldn't have it > > xgettext sees "% o" and interprets it as a placeholder for an octal > number preceded by a space. However, in this case it's not actually a > placeholder, and most translations will replace the "% o" sequence with > something else. Removing the tcl-format flag from this string prevents > tools like Poedit from freaking out when "% o" doesn't appear in the > translated string. > > The corrected flag will appear in each translation's po file the next time > the translation is updated with `make update-po`. > > Signed-off-by: Alex Henrie Thanks, applied. Paul. ```