{"thread":{"id":"38426","subject":"[PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","startedAt":"2015-01-22T08:19:39Z","lastAt":"2015-03-22T03:40:12Z","messageCount":7,"participants":["Alex Henrie","Junio C Hamano","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"255071","messageId":"1421914779-30865-1-git-send-email-alexhenrie24@gmail.com","threadId":"38426","inReplyTo":null,"subject":"[PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-01-22T08:19:39Z","receivedAt":"2015-01-22T08:19:39Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"xgettext sees \"% o\" and interprets it as a placeholder for an octal\nnumber preceded by a space. However, in this case it's not actually a\nplaceholder, and most translations will replace the \"% o\" sequence with\nsomething else. Removing the tcl-format flag from this string prevents\ntools like Poedit from freaking out when \"% o\" doesn't appear in the\ntranslated string.\n\nThe corrected flag will appear in each translation's po file the next time\nthe translation is updated with `make update-po`.\n\nSigned-off-by: Alex Henrie \n---\n gitk-git/gitk | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/gitk-git/gitk b/gitk-git/gitk\nindex 78358a7..dfd458d 100755\n--- a/gitk-git/gitk\n+++ b/gitk-git/gitk\n@@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} {\n ${NS}::label $page.maxwidthl -text [mc \"Maximum graph width (lines)\"]\n spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth\n grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w\n+ #xgettext:no-tcl-format\n ${NS}::label $page.maxpctl -text [mc \"Maximum graph width (% of pane)\"]\n spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct\n grid x $page.maxpctl $page.maxpct -sticky w\n-- \n2.2.2\n"},{"id":"255857","messageId":"CAMMLpeTvtzPuiQJVxAx-Ja4JsoUxih5azMaN7_RcLvajny6A6g@mail.gmail.com","threadId":"38426","inReplyTo":"1421914779-30865-1-git-send-email-alexhenrie24@gmail.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-02-09T21:36:51Z","receivedAt":"2015-02-09T21:36:51Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"Hi,\n\nThis is just a friendly reminder that this patch has been sitting in\nthe mailing list archives for a couple of weeks, and it has not yet\nbeen accepted or commented on.\n\n-Alex\n"},{"id":"255862","messageId":"xmqqlhk6agxg.fsf@gitster.dls.corp.google.com","threadId":"38426","inReplyTo":"CAMMLpeTvtzPuiQJVxAx-Ja4JsoUxih5azMaN7_RcLvajny6A6g@mail.gmail.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-02-09T21:55:23Z","receivedAt":"2015-02-09T21:55:23Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alex Henrie writes:\n\n> This is just a friendly reminder that this patch has been sitting in\n> the mailing list archives for a couple of weeks, and it has not yet\n> been accepted or commented on.\n\nI think that is because the message was not sent to the right\npeople, and also because the patch was made against a wrong project\n;-).\n\nI'll forward it to the gitk maintainer after digging it out of the\narchive and tweaking it. Thanks.\n\nPaul, comments?\n\n-- >8 --\nFrom: Alex Henrie \nDate: Thu, 22 Jan 2015 01:19:39 -0700\nSubject: gitk: Remove tcl-format flag from a message that shouldn't have it\n\nxgettext sees \"% o\" and interprets it as a placeholder for an octal\nnumber preceded by a space. However, in this case it's not actually a\nplaceholder, and most translations will replace the \"% o\" sequence with\nsomething else. Removing the tcl-format flag from this string prevents\ntools like Poedit from freaking out when \"% o\" doesn't appear in the\ntranslated string.\n\nThe corrected flag will appear in each translation's po file the next time\nthe translation is updated with `make update-po`.\n\nSigned-off-by: Alex Henrie \n---\n gitk | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/gitk b/gitk\nindex 78358a7..dfd458d 100755\n--- a/gitk\n+++ b/gitk\n@@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} {\n ${NS}::label $page.maxwidthl -text [mc \"Maximum graph width (lines)\"]\n spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth\n grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w\n+ #xgettext:no-tcl-format\n ${NS}::label $page.maxpctl -text [mc \"Maximum graph width (% of pane)\"]\n spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct\n grid x $page.maxpctl $page.maxpct -sticky w\n-- \n2.2.2\n"},{"id":"256176","messageId":"CAMMLpeR6TkZxFQBVJukC3KgXM-cJkRY31m8OthHxMkaZzLqGjg@mail.gmail.com","threadId":"38426","inReplyTo":"xmqqlhk6agxg.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-02-16T23:27:12Z","receivedAt":"2015-02-16T23:27:12Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"2015-02-09 14:55 GMT-07:00 Junio C Hamano :\n>\n> Alex Henrie writes:\n>\n> > This is just a friendly reminder that this patch has been sitting in\n> > the mailing list archives for a couple of weeks, and it has not yet\n> > been accepted or commented on.\n>\n> I think that is because the message was not sent to the right\n> people, and also because the patch was made against a wrong project\n> ;-).\n>\n> I'll forward it to the gitk maintainer after digging it out of the\n> archive and tweaking it. Thanks.\n>\n> Paul, comments?\n\nAnother week and still no comments on either this patch or the gitk\nCatalan translation patch. Is Paul Mackerras still actively involved\nin the project?\n\n-Alex\n"},{"id":"256550","messageId":"CAMMLpeQ0fyNm1pdF6iDBzh8q__g6H8Obgwg3mD680CydmCwfVw@mail.gmail.com","threadId":"38426","inReplyTo":"CAMMLpeR6TkZxFQBVJukC3KgXM-cJkRY31m8OthHxMkaZzLqGjg@mail.gmail.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-02-23T22:30:37Z","receivedAt":"2015-02-23T22:30:37Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"2015-02-16 16:27 GMT-07:00 Alex Henrie :\n> 2015-02-09 14:55 GMT-07:00 Junio C Hamano :\n>>\n>> Alex Henrie writes:\n>>\n>> > This is just a friendly reminder that this patch has been sitting in\n>> > the mailing list archives for a couple of weeks, and it has not yet\n>> > been accepted or commented on.\n>>\n>> I think that is because the message was not sent to the right\n>> people, and also because the patch was made against a wrong project\n>> ;-).\n>>\n>> I'll forward it to the gitk maintainer after digging it out of the\n>> archive and tweaking it. Thanks.\n>>\n>> Paul, comments?\n>\n> Another week and still no comments on either this patch or the gitk\n> Catalan translation patch. Is Paul Mackerras still actively involved\n> in the project?\n>\n> -Alex\n\nAnother week and still no response. If Paul is no longer maintaining\ngitk, another maintainer should be appointed.\n\n-Alex\n"},{"id":"257488","messageId":"CAMMLpeQWTzAsWwX2rsVhGLz4ZMcEsZw=auGeUeYow-P2kCM3Sg@mail.gmail.com","threadId":"38426","inReplyTo":"CAMMLpeQ0fyNm1pdF6iDBzh8q__g6H8Obgwg3mD680CydmCwfVw@mail.gmail.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2015-03-10T18:53:42Z","receivedAt":"2015-03-10T18:53:42Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"2015-02-23 15:30 GMT-07:00 Alex Henrie :\n> 2015-02-16 16:27 GMT-07:00 Alex Henrie :\n>> 2015-02-09 14:55 GMT-07:00 Junio C Hamano :\n>>>\n>>> Alex Henrie writes:\n>>>\n>>> > This is just a friendly reminder that this patch has been sitting in\n>>> > the mailing list archives for a couple of weeks, and it has not yet\n>>> > been accepted or commented on.\n>>>\n>>> I think that is because the message was not sent to the right\n>>> people, and also because the patch was made against a wrong project\n>>> ;-).\n>>>\n>>> I'll forward it to the gitk maintainer after digging it out of the\n>>> archive and tweaking it. Thanks.\n>>>\n>>> Paul, comments?\n>>\n>> Another week and still no comments on either this patch or the gitk\n>> Catalan translation patch. Is Paul Mackerras still actively involved\n>> in the project?\n>>\n>> -Alex\n>\n> Another week and still no response. If Paul is no longer maintaining\n> gitk, another maintainer should be appointed.\n>\n> -Alex\n\nI am unsubscribing from the Git mailing list. As far as I can tell,\nthe gitk project does not accept patches, not even translations into\nnew languages. If this policy ever changes, please email me directly.\n\n-Alex\n"},{"id":"258265","messageId":"20150322034012.GD14271@iris.ozlabs.ibm.com","threadId":"38426","inReplyTo":"xmqqlhk6agxg.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2015-03-22T03:40:12Z","receivedAt":"2015-03-22T03:40:12Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote:\n> Alex Henrie writes:\n> \n> > This is just a friendly reminder that this patch has been sitting in\n> > the mailing list archives for a couple of weeks, and it has not yet\n> > been accepted or commented on.\n> \n> I think that is because the message was not sent to the right\n> people, and also because the patch was made against a wrong project\n> ;-).\n> \n> I'll forward it to the gitk maintainer after digging it out of the\n> archive and tweaking it. Thanks.\n> \n> Paul, comments?\n> \n> -- >8 --\n> From: Alex Henrie \n> Date: Thu, 22 Jan 2015 01:19:39 -0700\n> Subject: gitk: Remove tcl-format flag from a message that shouldn't have it\n> \n> xgettext sees \"% o\" and interprets it as a placeholder for an octal\n> number preceded by a space. However, in this case it's not actually a\n> placeholder, and most translations will replace the \"% o\" sequence with\n> something else. Removing the tcl-format flag from this string prevents\n> tools like Poedit from freaking out when \"% o\" doesn't appear in the\n> translated string.\n> \n> The corrected flag will appear in each translation's po file the next time\n> the translation is updated with `make update-po`.\n> \n> Signed-off-by: Alex Henrie \n\nThanks, applied.\n\nPaul.\n"}]}