Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it
On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote:
Show 31 quoted lines
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > This is just a friendly reminder that this patch has been sitting in
> > the mailing list archives for a couple of weeks, and it has not yet
> > been accepted or commented on.
>
> I think that is because the message was not sent to the right
> people, and also because the patch was made against a wrong project
> ;-).
>
> I'll forward it to the gitk maintainer after digging it out of the
> archive and tweaking it. Thanks.
>
> Paul, comments?
>
> -- >8 --
> From: Alex Henrie <alexhenrie24@gmail.com>
> Date: Thu, 22 Jan 2015 01:19:39 -0700
> Subject: gitk: Remove tcl-format flag from a message that shouldn't have it
>
> xgettext sees "% o" and interprets it as a placeholder for an octal
> number preceded by a space. However, in this case it's not actually a
> placeholder, and most translations will replace the "% o" sequence with
> something else. Removing the tcl-format flag from this string prevents
> tools like Poedit from freaking out when "% o" doesn't appear in the
> translated string.
>
> The corrected flag will appear in each translation's po file the next time
> the translation is updated with `make update-po`.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>