git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

From
Paul Mackerras <paulus@samba.org>
Date
Mar 22, 2015, 03:40 UTC
Message-ID
<20150322034012.GD14271@iris.ozlabs.ibm.com>
In-Reply-To
<xmqqlhk6agxg.fsf@gitster.dls.corp.google.com>
On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote:
Show 31 quoted lines
> Alex Henrie <alexhenrie24@gmail.com> writes:
> 
> > This is just a friendly reminder that this patch has been sitting in
> > the mailing list archives for a couple of weeks, and it has not yet
> > been accepted or commented on.
> 
> I think that is because the message was not sent to the right
> people, and also because the patch was made against a wrong project
> ;-).
> 
> I'll forward it to the gitk maintainer after digging it out of the
> archive and tweaking it.  Thanks.
> 
> Paul, comments?
> 
> -- >8 --
> From: Alex Henrie <alexhenrie24@gmail.com>
> Date: Thu, 22 Jan 2015 01:19:39 -0700
> Subject: gitk: Remove tcl-format flag from a message that shouldn't have it
> 
> xgettext sees "% o" and interprets it as a placeholder for an octal
> number preceded by a space. However, in this case it's not actually a
> placeholder, and most translations will replace the "% o" sequence with
> something else. Removing the tcl-format flag from this string prevents
> tools like Poedit from freaking out when "% o" doesn't appear in the
> translated string.
> 
> The corrected flag will appear in each translation's po file the next time
> the translation is updated with `make update-po`.
> 
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Thanks, applied.
Paul.
Previous: Alex Henrie
Message 7 of 7 in “gitk: Remove tcl-format flag from a message that shouldn't have it”
  1. gitk: Remove tcl-format flag from a message that shouldn't have itAlex Henrie, Jan 22, 2015
  2. Alex HenrieFeb 9, 2015
  3. Junio C HamanoFeb 9, 2015
  4. Alex HenrieFeb 16, 2015
  5. Alex HenrieFeb 23, 2015
  6. Alex HenrieMar 10, 2015
  7. Paul MackerrasMar 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.