git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it

From
Alex Henrie <alexhenrie24@gmail.com>
Date
Jan 22, 2015, 08:19 UTC
Message-ID
<1421914779-30865-1-git-send-email-alexhenrie24@gmail.com>

xgettext sees "% o" and interprets it as a placeholder for an octal number preceded by a space. However, in this case it's not actually a placeholder, and most translations will replace the "% o" sequence with something else. Removing the tcl-format flag from this string prevents tools like Poedit from freaking out when "% o" doesn't appear in the translated string.

The corrected flag will appear in each translation's po file the next time the translation is updated with `make update-po`.

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
---
 gitk-git/gitk | 1 +
 1 file changed, 1 insertion(+)
diff --git a/gitk-git/gitk b/gitk-git/gitk
index 78358a7..dfd458d 100755
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11237,6 +11237,7 @@ proc prefspage_general {notebook} {
     ${NS}::label $page.maxwidthl -text [mc "Maximum graph width (lines)"]
     spinbox $page.maxwidth -from 0 -to 100 -width 4 -textvariable maxwidth
     grid $page.spacer $page.maxwidthl $page.maxwidth -sticky w
+                                         #xgettext:no-tcl-format
     ${NS}::label $page.maxpctl -text [mc "Maximum graph width (% of pane)"]
     spinbox $page.maxpct -from 1 -to 100 -width 4 -textvariable maxgraphpct
     grid x $page.maxpctl $page.maxpct -sticky w
-- 
2.2.2
Next: Alex Henrie
Message 1 of 7 in “gitk: Remove tcl-format flag from a message that shouldn't have it”
  1. gitk: Remove tcl-format flag from a message that shouldn't have itAlex Henrie, Jan 22, 2015
  2. Alex HenrieFeb 9, 2015
  3. Junio C HamanoFeb 9, 2015
  4. Alex HenrieFeb 16, 2015
  5. Alex HenrieFeb 23, 2015
  6. Alex HenrieMar 10, 2015
  7. Paul MackerrasMar 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.