threads / patch / 31965

patchpathspec.c: Fix some sparse warnings

Subject: [PATCH] pathspec.c: Fix some sparse warnings

## tl;dr

3 messages between Oct 28, 2012 and Oct 29, 2012. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· Oct 28, 2012, 21:09 UTC · lore

Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Nguyen,

I asked Adam to squash this patch into his 'as/check-ignore' branch when he next re-rolled the branch. However, it appears that you resubmitted that branch instead ... :-D

I don't know if this branch is ready to progress to next yet, but could somebody (yourself, Adam or Jeff?) please squash this into commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") before it hits next.

Thanks!

ATB, Ramsay Jones

 pathspec.c | 1 +
 1 file changed, 1 insertion(+)

Show changes to pathspec.c +1 −0

diff --git a/pathspec.c b/pathspec.c
index a9c5b5b..efdabe4 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "dir.h"
+#include "pathspec.h"
 
 void validate_path(const char *prefix, const char *path)
 {

-- 
1.8.0

Adam Spiers· Oct 28, 2012, 23:31 UTC · re: Ramsay Jones · lore

Re: [PATCH] pathspec.c: Fix some sparse warnings

On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 18 quoted lines

> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Nguyen,
>
> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
>
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.

Noted - thanks a lot Ramsay. My diary is a bit gentler this week so I'm hoping to get some attention back on these patch series.

Jeff King· Oct 29, 2012, 05:55 UTC · re: Ramsay Jones · lore

Re: [PATCH] pathspec.c: Fix some sparse warnings

On Sun, Oct 28, 2012 at 09:09:19PM +0000, Ramsay Jones wrote:

Show 8 quoted lines

> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
> 
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.

I squashed it into my version of as/check-ignore, but if we are expecting a re-roll, please everybody remember to include it.

-Peff