git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] pathspec.c: Fix some sparse warnings

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Oct 28, 2012, 21:09 UTC
Message-ID
<508D9EFF.3040900@ramsay1.demon.co.uk>

Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Nguyen,

I asked Adam to squash this patch into his 'as/check-ignore' branch when he next re-rolled the branch. However, it appears that you resubmitted that branch instead ... :-D

I don't know if this branch is ready to progress to next yet, but could somebody (yourself, Adam or Jeff?) please squash this into commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") before it hits next.

Thanks!

ATB, Ramsay Jones

 pathspec.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/pathspec.c b/pathspec.c
index a9c5b5b..efdabe4 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -1,5 +1,6 @@
 #include "cache.h"
 #include "dir.h"
+#include "pathspec.h"
 
 void validate_path(const char *prefix, const char *path)
 {
-- 
1.8.0
Next: Adam Spiers
Message 1 of 3 in “pathspec.c: Fix some sparse warnings”
  1. pathspec.c: Fix some sparse warningsRamsay Jones, Oct 28, 2012
  2. Adam SpiersOct 28, 2012
  3. Jeff KingOct 29, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.