{"thread":{"id":"31965","subject":"[PATCH] pathspec.c: Fix some sparse warnings","startedAt":"2012-10-28T21:09:19Z","lastAt":"2012-10-29T05:55:00Z","messageCount":3,"participants":["Ramsay Jones","Adam Spiers","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"202066","messageId":"508D9EFF.3040900@ramsay1.demon.co.uk","threadId":"31965","inReplyTo":null,"subject":"[PATCH] pathspec.c: Fix some sparse warnings","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2012-10-28T21:09:19Z","receivedAt":"2012-10-28T21:09:19Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse issues a warning for all six external symbols defined in this\nfile. In order to suppress the warnings, we include the 'pathspec.h'\nheader file, which contains the relevant extern declarations for these\nsymbols.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Nguyen,\n\nI asked Adam to squash this patch into his 'as/check-ignore' branch\nwhen he next re-rolled the branch. However, it appears that you\nresubmitted that branch instead ... :-D\n\nI don't know if this branch is ready to progress to next yet, but\ncould somebody (yourself, Adam or Jeff?) please squash this into\ncommit 1a88ae42 (\"pathspec.c: move reusable code from builtin/add.c\")\nbefore it hits next.\n\nThanks!\n\nATB,\nRamsay Jones\n\n pathspec.c | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/pathspec.c b/pathspec.c\nindex a9c5b5b..efdabe4 100644\n--- a/pathspec.c\n+++ b/pathspec.c\n@@ -1,5 +1,6 @@\n #include \"cache.h\"\n #include \"dir.h\"\n+#include \"pathspec.h\"\n \n void validate_path(const char *prefix, const char *path)\n {\n-- \n1.8.0\n"},{"id":"202074","messageId":"CAOkDyE8BF2u0zqpZb9eQQ_hsNWzYhf1=DteAFK3QXmAONjGVbQ@mail.gmail.com","threadId":"31965","inReplyTo":"508D9EFF.3040900@ramsay1.demon.co.uk","subject":"Re: [PATCH] pathspec.c: Fix some sparse warnings","fromName":"Adam Spiers","fromEmail":"git@adamspiers.org","sentAt":"2012-10-28T23:31:35Z","receivedAt":"2012-10-28T23:31:35Z","isPatch":true,"sender":{"key":"git@adamspiers.org","avatar":"https://avatars.githubusercontent.com/u/100738?v=4"},"body":"On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n> Sparse issues a warning for all six external symbols defined in this\n> file. In order to suppress the warnings, we include the 'pathspec.h'\n> header file, which contains the relevant extern declarations for these\n> symbols.\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Nguyen,\n>\n> I asked Adam to squash this patch into his 'as/check-ignore' branch\n> when he next re-rolled the branch. However, it appears that you\n> resubmitted that branch instead ... :-D\n>\n> I don't know if this branch is ready to progress to next yet, but\n> could somebody (yourself, Adam or Jeff?) please squash this into\n> commit 1a88ae42 (\"pathspec.c: move reusable code from builtin/add.c\")\n> before it hits next.\n\nNoted - thanks a lot Ramsay.  My diary is a bit gentler this week so\nI'm hoping to get some attention back on these patch series.\n"},{"id":"202087","messageId":"20121029055500.GA4457@sigill.intra.peff.net","threadId":"31965","inReplyTo":"508D9EFF.3040900@ramsay1.demon.co.uk","subject":"Re: [PATCH] pathspec.c: Fix some sparse warnings","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2012-10-29T05:55:00Z","receivedAt":"2012-10-29T05:55:00Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Oct 28, 2012 at 09:09:19PM +0000, Ramsay Jones wrote:\n\n> I asked Adam to squash this patch into his 'as/check-ignore' branch\n> when he next re-rolled the branch. However, it appears that you\n> resubmitted that branch instead ... :-D\n> \n> I don't know if this branch is ready to progress to next yet, but\n> could somebody (yourself, Adam or Jeff?) please squash this into\n> commit 1a88ae42 (\"pathspec.c: move reusable code from builtin/add.c\")\n> before it hits next.\n\nI squashed it into my version of as/check-ignore, but if we are\nexpecting a re-roll, please everybody remember to include it.\n\n-Peff\n"}]}