# [PATCH] pathspec.c: Fix some sparse warnings 3 messages from 2012-10-28 to 2012-10-29. Participants: Ramsay Jones, Adam Spiers, Jeff King. Thread: https://gitlist.dev/t/31965 ## Ramsay Jones, 2012-10-28 21:09 Subject: [PATCH] pathspec.c: Fix some sparse warnings Message-ID: <508D9EFF.3040900@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/508D9EFF.3040900%40ramsay1.demon.co.uk ``` Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols. Signed-off-by: Ramsay Jones --- Hi Nguyen, I asked Adam to squash this patch into his 'as/check-ignore' branch when he next re-rolled the branch. However, it appears that you resubmitted that branch instead ... :-D I don't know if this branch is ready to progress to next yet, but could somebody (yourself, Adam or Jeff?) please squash this into commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") before it hits next. Thanks! ATB, Ramsay Jones pathspec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pathspec.c b/pathspec.c index a9c5b5b..efdabe4 100644 --- a/pathspec.c +++ b/pathspec.c @@ -1,5 +1,6 @@ #include "cache.h" #include "dir.h" +#include "pathspec.h" void validate_path(const char *prefix, const char *path) { -- 1.8.0 ``` ## Adam Spiers, 2012-10-28 23:31 Subject: Re: [PATCH] pathspec.c: Fix some sparse warnings Message-ID: URL: https://gitlist.dev/e/CAOkDyE8BF2u0zqpZb9eQQ_hsNWzYhf1%3DDteAFK3QXmAONjGVbQ%40mail.gmail.com In-Reply-To: <508D9EFF.3040900@ramsay1.demon.co.uk> ``` On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones wrote: > Sparse issues a warning for all six external symbols defined in this > file. In order to suppress the warnings, we include the 'pathspec.h' > header file, which contains the relevant extern declarations for these > symbols. > > Signed-off-by: Ramsay Jones > --- > > Hi Nguyen, > > I asked Adam to squash this patch into his 'as/check-ignore' branch > when he next re-rolled the branch. However, it appears that you > resubmitted that branch instead ... :-D > > I don't know if this branch is ready to progress to next yet, but > could somebody (yourself, Adam or Jeff?) please squash this into > commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") > before it hits next. Noted - thanks a lot Ramsay. My diary is a bit gentler this week so I'm hoping to get some attention back on these patch series. ``` ## Jeff King, 2012-10-29 05:55 Subject: Re: [PATCH] pathspec.c: Fix some sparse warnings Message-ID: <20121029055500.GA4457@sigill.intra.peff.net> URL: https://gitlist.dev/e/20121029055500.GA4457%40sigill.intra.peff.net In-Reply-To: <508D9EFF.3040900@ramsay1.demon.co.uk> ``` On Sun, Oct 28, 2012 at 09:09:19PM +0000, Ramsay Jones wrote: > I asked Adam to squash this patch into his 'as/check-ignore' branch > when he next re-rolled the branch. However, it appears that you > resubmitted that branch instead ... :-D > > I don't know if this branch is ready to progress to next yet, but > could somebody (yourself, Adam or Jeff?) please squash this into > commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") > before it hits next. I squashed it into my version of as/check-ignore, but if we are expecting a re-roll, please everybody remember to include it. -Peff ```