Re: [PATCH] pathspec.c: Fix some sparse warnings

From: Adam Spiers <git@adamspiers.org>
Date: Oct 28, 2012, 23:31 UTC
Message-ID: <CAOkDyE8BF2u0zqpZb9eQQ_hsNWzYhf1=DteAFK3QXmAONjGVbQ@mail.gmail.com>
In-Reply-To: <508D9EFF.3040900@ramsay1.demon.co.uk>

On Sun, Oct 28, 2012 at 9:09 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 18 quoted lines

> Sparse issues a warning for all six external symbols defined in this
> file. In order to suppress the warnings, we include the 'pathspec.h'
> header file, which contains the relevant extern declarations for these
> symbols.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Nguyen,
>
> I asked Adam to squash this patch into his 'as/check-ignore' branch
> when he next re-rolled the branch. However, it appears that you
> resubmitted that branch instead ... :-D
>
> I don't know if this branch is ready to progress to next yet, but
> could somebody (yourself, Adam or Jeff?) please squash this into
> commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c")
> before it hits next.

Noted - thanks a lot Ramsay. My diary is a bit gentler this week so I'm hoping to get some attention back on these patch series.