threads / patch / 28765

patchgitweb/Makefile: Remove static/gitweb.js in the clean target

Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

## tl;dr

6 messages between Oct 25, 2011 and Oct 29, 2011. Diffs are folded; open one to read it.

replies: 5people: 4as markdown or json

Ramsay Jones· Oct 25, 2011, 17:15 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to gitweb/Makefile +3 −1

diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE

-- 
1.7.7

Drew Northup· Oct 25, 2011, 22:58 UTC · re: Ramsay Jones · lore

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:

Show 20 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>  gitweb/Makefile |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/gitweb/Makefile b/gitweb/Makefile
> index 1c85b5f..4191c6b 100644
> --- a/gitweb/Makefile
> +++ b/gitweb/Makefile
> @@ -185,7 +185,9 @@ install: all
>  ### Cleaning rules
>  
>  clean:
> -	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> +	$(RM) gitweb.cgi static/gitweb.js \
> +		static/gitweb.min.js static/gitweb.min.css \
> +		GITWEB-BUILD-OPTIONS
>  
>  .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
>

Forgive me for sounding a bit numb, but what does this fix? I don't see it in the commit message.

-- 
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59

Jakub Narebski· Oct 26, 2011, 00:36 UTC · re: Drew Northup · lore

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Drew Northup napisał:

Show 24 quoted lines

> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> > ---
> >  gitweb/Makefile |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/gitweb/Makefile b/gitweb/Makefile
> > index 1c85b5f..4191c6b 100644
> > --- a/gitweb/Makefile
> > +++ b/gitweb/Makefile
> > @@ -185,7 +185,9 @@ install: all
> >  ### Cleaning rules
> >  
> >  clean:
> > -	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> > +	$(RM) gitweb.cgi static/gitweb.js \
> > +		static/gitweb.min.js static/gitweb.min.css \
> > +		GITWEB-BUILD-OPTIONS
> >  
> >  .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
> >  
> 
> Forgive me for sounding a bit numb, but what does this fix? I don't see
> it in the commit message.

gitweb.js is nowadays a generated file. Though that bit should be in commit message...

-- 
Jakub Narebski
Poland

Ramsay Jones· Oct 26, 2011, 21:30 UTC · re: Jakub Narebski · lore

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Jakub Narebski wrote:

Show 27 quoted lines

> Drew Northup napisał:
>> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
>>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>>> ---
>>>  gitweb/Makefile |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/gitweb/Makefile b/gitweb/Makefile
>>> index 1c85b5f..4191c6b 100644
>>> --- a/gitweb/Makefile
>>> +++ b/gitweb/Makefile
>>> @@ -185,7 +185,9 @@ install: all
>>>  ### Cleaning rules
>>>  
>>>  clean:
>>> -	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
>>> +	$(RM) gitweb.cgi static/gitweb.js \
>>> +		static/gitweb.min.js static/gitweb.min.css \
>>> +		GITWEB-BUILD-OPTIONS
>>>  
>>>  .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
>>>  
>> Forgive me for sounding a bit numb, but what does this fix? I don't see
>> it in the commit message.
> 
> gitweb.js is nowadays a generated file.  Though that bit should be
> in commit message...

Yep, will do ...

ATB, Ramsay Jones

Junio C Hamano· Oct 27, 2011, 17:49 UTC · re: Ramsay Jones · lore

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

>> gitweb.js is nowadays a generated file.  Though that bit should be
>> in commit message...
>
> Yep, will do ...

Thanks; here is what I already queued.

-- >8 --
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Tue, 25 Oct 2011 18:15:20 +0100
Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Since 9a86dd5 (gitweb: Split JavaScript for maintability, combining on build, 2011-04-28), static/gitweb.js has been a build product that should be cleaned upon "make clean".

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Show changes to gitweb/Makefile +3 −1

diff --git a/gitweb/Makefile b/gitweb/Makefile
index 5d20515..c360284 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -183,7 +183,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE

-- 
1.7.7.1.552.g2c3d8

Ramsay Jones· Oct 29, 2011, 19:59 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Junio C Hamano wrote:

Show 7 quoted lines

> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>>> gitweb.js is nowadays a generated file.  Though that bit should be
>>> in commit message...
>> Yep, will do ...
> 
> Thanks; here is what I already queued.

Yeah, I saw this about two hours after I sent those emails ... Also, I prefer your commit message! ;-)

Thanks.

ATB, Ramsay Jones