git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 27, 2011, 17:49 UTC
Message-ID
<7vk47qz5na.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4EA87C06.8080808@ramsay1.demon.co.uk>
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>> gitweb.js is nowadays a generated file.  Though that bit should be
>> in commit message...
>
> Yep, will do ...
Thanks; here is what I already queued.
-- >8 --
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Tue, 25 Oct 2011 18:15:20 +0100
Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

Since 9a86dd5 (gitweb: Split JavaScript for maintability, combining on build, 2011-04-28), static/gitweb.js has been a build product that should be cleaned upon "make clean".

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 gitweb/Makefile |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 5d20515..c360284 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -183,7 +183,9 @@ install: all
 ### Cleaning rules
 
 clean:
-	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+	$(RM) gitweb.cgi static/gitweb.js \
+		static/gitweb.min.js static/gitweb.min.css \
+		GITWEB-BUILD-OPTIONS
 
 .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
 
-- 
1.7.7.1.552.g2c3d8
Previous: Ramsay JonesNext: Ramsay Jones
Message 5 of 6 in “gitweb/Makefile: Remove static/gitweb.js in the clean target”
  1. gitweb/Makefile: Remove static/gitweb.js in the clean targetRamsay Jones, Oct 25, 2011
  2. Drew NorthupOct 25, 2011
  3. Jakub NarebskiOct 26, 2011
  4. Ramsay JonesOct 26, 2011
  5. Junio C HamanoOct 27, 2011
  6. Ramsay JonesOct 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.