{"thread":{"id":"28765","subject":"[PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","startedAt":"2011-10-25T17:15:20Z","lastAt":"2011-10-29T19:59:53Z","messageCount":6,"participants":["Ramsay Jones","Drew Northup","Jakub Narebski","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"178285","messageId":"4EA6EEA8.3000204@ramsay1.demon.co.uk","threadId":"28765","inReplyTo":null,"subject":"[PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-10-25T17:15:20Z","receivedAt":"2011-10-25T17:15:20Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n gitweb/Makefile | 4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/Makefile b/gitweb/Makefile\nindex 1c85b5f..4191c6b 100644\n--- a/gitweb/Makefile\n+++ b/gitweb/Makefile\n@@ -185,7 +185,9 @@ install: all\n ### Cleaning rules\n \n clean:\n-\t$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS\n+\t$(RM) gitweb.cgi static/gitweb.js \\\n+\t\tstatic/gitweb.min.js static/gitweb.min.css \\\n+\t\tGITWEB-BUILD-OPTIONS\n \n .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE\n \n-- \n1.7.7\n"},{"id":"178300","messageId":"1319583484.10399.41.camel@drew-northup.unet.maine.edu","threadId":"28765","inReplyTo":"4EA6EEA8.3000204@ramsay1.demon.co.uk","subject":"Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Drew Northup","fromEmail":"drew.northup@maine.edu","sentAt":"2011-10-25T22:58:04Z","receivedAt":"2011-10-25T22:58:04Z","isPatch":true,"sender":{"key":"drew.northup@maine.edu","avatar":"https://avatars.githubusercontent.com/u/18331571?v=4"},"body":"\nOn Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:\n> Signed-off-by: Ramsay Jones \n> ---\n> gitweb/Makefile | 4 +++-\n> 1 files changed, 3 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitweb/Makefile b/gitweb/Makefile\n> index 1c85b5f..4191c6b 100644\n> --- a/gitweb/Makefile\n> +++ b/gitweb/Makefile\n> @@ -185,7 +185,9 @@ install: all\n> ### Cleaning rules\n> \n> clean:\n> -\t$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS\n> +\t$(RM) gitweb.cgi static/gitweb.js \\\n> +\t\tstatic/gitweb.min.js static/gitweb.min.css \\\n> +\t\tGITWEB-BUILD-OPTIONS\n> \n> .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE\n> \n\nForgive me for sounding a bit numb, but what does this fix? I don't see\nit in the commit message.\n\n-- \n-Drew Northup\n________________________________________________\n\"As opposed to vegetable or mineral error?\"\n-John Pescatore, SANS NewsBites Vol. 12 Num. 59\n"},{"id":"178304","messageId":"201110260236.59509.jnareb@gmail.com","threadId":"28765","inReplyTo":"1319583484.10399.41.camel@drew-northup.unet.maine.edu","subject":"Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2011-10-26T00:36:58Z","receivedAt":"2011-10-26T00:36:58Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Drew Northup napisał:\n> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:\n> > Signed-off-by: Ramsay Jones \n> > ---\n> > gitweb/Makefile | 4 +++-\n> > 1 files changed, 3 insertions(+), 1 deletions(-)\n> > \n> > diff --git a/gitweb/Makefile b/gitweb/Makefile\n> > index 1c85b5f..4191c6b 100644\n> > --- a/gitweb/Makefile\n> > +++ b/gitweb/Makefile\n> > @@ -185,7 +185,9 @@ install: all\n> > ### Cleaning rules\n> > \n> > clean:\n> > -\t$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS\n> > +\t$(RM) gitweb.cgi static/gitweb.js \\\n> > +\t\tstatic/gitweb.min.js static/gitweb.min.css \\\n> > +\t\tGITWEB-BUILD-OPTIONS\n> > \n> > .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE\n> > \n> \n> Forgive me for sounding a bit numb, but what does this fix? I don't see\n> it in the commit message.\n\ngitweb.js is nowadays a generated file. Though that bit should be\nin commit message...\n\n-- \nJakub Narebski\nPoland\n"},{"id":"178359","messageId":"4EA87C06.8080808@ramsay1.demon.co.uk","threadId":"28765","inReplyTo":"201110260236.59509.jnareb@gmail.com","subject":"Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-10-26T21:30:46Z","receivedAt":"2011-10-26T21:30:46Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Jakub Narebski wrote:\n> Drew Northup napisał:\n>> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:\n>>> Signed-off-by: Ramsay Jones \n>>> ---\n>>> gitweb/Makefile | 4 +++-\n>>> 1 files changed, 3 insertions(+), 1 deletions(-)\n>>>\n>>> diff --git a/gitweb/Makefile b/gitweb/Makefile\n>>> index 1c85b5f..4191c6b 100644\n>>> --- a/gitweb/Makefile\n>>> +++ b/gitweb/Makefile\n>>> @@ -185,7 +185,9 @@ install: all\n>>> ### Cleaning rules\n>>> \n>>> clean:\n>>> -\t$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS\n>>> +\t$(RM) gitweb.cgi static/gitweb.js \\\n>>> +\t\tstatic/gitweb.min.js static/gitweb.min.css \\\n>>> +\t\tGITWEB-BUILD-OPTIONS\n>>> \n>>> .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE\n>>> \n>> Forgive me for sounding a bit numb, but what does this fix? I don't see\n>> it in the commit message.\n> \n> gitweb.js is nowadays a generated file. Though that bit should be\n> in commit message...\n\nYep, will do ...\n\nATB,\nRamsay Jones\n"},{"id":"178367","messageId":"7vk47qz5na.fsf@alter.siamese.dyndns.org","threadId":"28765","inReplyTo":"4EA87C06.8080808@ramsay1.demon.co.uk","subject":"Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-10-27T17:49:29Z","receivedAt":"2011-10-27T17:49:29Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones writes:\n\n>> gitweb.js is nowadays a generated file. Though that bit should be\n>> in commit message...\n>\n> Yep, will do ...\n\nThanks; here is what I already queued.\n\n-- >8 --\nFrom: Ramsay Jones \nDate: Tue, 25 Oct 2011 18:15:20 +0100\nSubject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target\n\nSince 9a86dd5 (gitweb: Split JavaScript for maintability, combining on\nbuild, 2011-04-28), static/gitweb.js has been a build product that should\nbe cleaned upon \"make clean\".\n\nSigned-off-by: Ramsay Jones \nSigned-off-by: Junio C Hamano \n---\n gitweb/Makefile | 4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/Makefile b/gitweb/Makefile\nindex 5d20515..c360284 100644\n--- a/gitweb/Makefile\n+++ b/gitweb/Makefile\n@@ -183,7 +183,9 @@ install: all\n ### Cleaning rules\n \n clean:\n-\t$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS\n+\t$(RM) gitweb.cgi static/gitweb.js \\\n+\t\tstatic/gitweb.min.js static/gitweb.min.css \\\n+\t\tGITWEB-BUILD-OPTIONS\n \n .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE\n \n-- \n1.7.7.1.552.g2c3d8\n"},{"id":"178532","messageId":"4EAC5B39.7070909@ramsay1.demon.co.uk","threadId":"28765","inReplyTo":"7vk47qz5na.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-10-29T19:59:53Z","receivedAt":"2011-10-29T19:59:53Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Junio C Hamano wrote:\n> Ramsay Jones writes:\n> \n>>> gitweb.js is nowadays a generated file. Though that bit should be\n>>> in commit message...\n>> Yep, will do ...\n> \n> Thanks; here is what I already queued.\n\nYeah, I saw this about two hours after I sent those emails ...\nAlso, I prefer your commit message! ;-)\n\nThanks.\n\nATB,\nRamsay Jones\n"}]}