# [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target 6 messages from 2011-10-25 to 2011-10-29. Participants: Ramsay Jones, Drew Northup, Jakub Narebski, Junio C Hamano. Thread: https://gitlist.dev/t/28765 ## Ramsay Jones, 2011-10-25 17:15 Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <4EA6EEA8.3000204@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4EA6EEA8.3000204%40ramsay1.demon.co.uk ``` Signed-off-by: Ramsay Jones --- gitweb/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gitweb/Makefile b/gitweb/Makefile index 1c85b5f..4191c6b 100644 --- a/gitweb/Makefile +++ b/gitweb/Makefile @@ -185,7 +185,9 @@ install: all ### Cleaning rules clean: - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS + $(RM) gitweb.cgi static/gitweb.js \ + static/gitweb.min.js static/gitweb.min.css \ + GITWEB-BUILD-OPTIONS .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE -- 1.7.7 ``` ## Drew Northup, 2011-10-25 22:58 Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <1319583484.10399.41.camel@drew-northup.unet.maine.edu> URL: https://gitlist.dev/e/1319583484.10399.41.camel%40drew-northup.unet.maine.edu In-Reply-To: <4EA6EEA8.3000204@ramsay1.demon.co.uk> ``` On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote: > Signed-off-by: Ramsay Jones > --- > gitweb/Makefile | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/gitweb/Makefile b/gitweb/Makefile > index 1c85b5f..4191c6b 100644 > --- a/gitweb/Makefile > +++ b/gitweb/Makefile > @@ -185,7 +185,9 @@ install: all > ### Cleaning rules > > clean: > - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS > + $(RM) gitweb.cgi static/gitweb.js \ > + static/gitweb.min.js static/gitweb.min.css \ > + GITWEB-BUILD-OPTIONS > > .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE > Forgive me for sounding a bit numb, but what does this fix? I don't see it in the commit message. -- -Drew Northup ________________________________________________ "As opposed to vegetable or mineral error?" -John Pescatore, SANS NewsBites Vol. 12 Num. 59 ``` ## Jakub Narebski, 2011-10-26 00:36 Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <201110260236.59509.jnareb@gmail.com> URL: https://gitlist.dev/e/201110260236.59509.jnareb%40gmail.com In-Reply-To: <1319583484.10399.41.camel@drew-northup.unet.maine.edu> ``` Drew Northup napisał: > On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote: > > Signed-off-by: Ramsay Jones > > --- > > gitweb/Makefile | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/gitweb/Makefile b/gitweb/Makefile > > index 1c85b5f..4191c6b 100644 > > --- a/gitweb/Makefile > > +++ b/gitweb/Makefile > > @@ -185,7 +185,9 @@ install: all > > ### Cleaning rules > > > > clean: > > - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS > > + $(RM) gitweb.cgi static/gitweb.js \ > > + static/gitweb.min.js static/gitweb.min.css \ > > + GITWEB-BUILD-OPTIONS > > > > .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE > > > > Forgive me for sounding a bit numb, but what does this fix? I don't see > it in the commit message. gitweb.js is nowadays a generated file. Though that bit should be in commit message... -- Jakub Narebski Poland ``` ## Ramsay Jones, 2011-10-26 21:30 Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <4EA87C06.8080808@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4EA87C06.8080808%40ramsay1.demon.co.uk In-Reply-To: <201110260236.59509.jnareb@gmail.com> ``` Jakub Narebski wrote: > Drew Northup napisał: >> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote: >>> Signed-off-by: Ramsay Jones >>> --- >>> gitweb/Makefile | 4 +++- >>> 1 files changed, 3 insertions(+), 1 deletions(-) >>> >>> diff --git a/gitweb/Makefile b/gitweb/Makefile >>> index 1c85b5f..4191c6b 100644 >>> --- a/gitweb/Makefile >>> +++ b/gitweb/Makefile >>> @@ -185,7 +185,9 @@ install: all >>> ### Cleaning rules >>> >>> clean: >>> - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS >>> + $(RM) gitweb.cgi static/gitweb.js \ >>> + static/gitweb.min.js static/gitweb.min.css \ >>> + GITWEB-BUILD-OPTIONS >>> >>> .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE >>> >> Forgive me for sounding a bit numb, but what does this fix? I don't see >> it in the commit message. > > gitweb.js is nowadays a generated file. Though that bit should be > in commit message... Yep, will do ... ATB, Ramsay Jones ``` ## Junio C Hamano, 2011-10-27 17:49 Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <7vk47qz5na.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk47qz5na.fsf%40alter.siamese.dyndns.org In-Reply-To: <4EA87C06.8080808@ramsay1.demon.co.uk> ``` Ramsay Jones writes: >> gitweb.js is nowadays a generated file. Though that bit should be >> in commit message... > > Yep, will do ... Thanks; here is what I already queued. -- >8 -- From: Ramsay Jones Date: Tue, 25 Oct 2011 18:15:20 +0100 Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Since 9a86dd5 (gitweb: Split JavaScript for maintability, combining on build, 2011-04-28), static/gitweb.js has been a build product that should be cleaned upon "make clean". Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano --- gitweb/Makefile | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/gitweb/Makefile b/gitweb/Makefile index 5d20515..c360284 100644 --- a/gitweb/Makefile +++ b/gitweb/Makefile @@ -183,7 +183,9 @@ install: all ### Cleaning rules clean: - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS + $(RM) gitweb.cgi static/gitweb.js \ + static/gitweb.min.js static/gitweb.min.css \ + GITWEB-BUILD-OPTIONS .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE -- 1.7.7.1.552.g2c3d8 ``` ## Ramsay Jones, 2011-10-29 19:59 Subject: Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Message-ID: <4EAC5B39.7070909@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4EAC5B39.7070909%40ramsay1.demon.co.uk In-Reply-To: <7vk47qz5na.fsf@alter.siamese.dyndns.org> ``` Junio C Hamano wrote: > Ramsay Jones writes: > >>> gitweb.js is nowadays a generated file. Though that bit should be >>> in commit message... >> Yep, will do ... > > Thanks; here is what I already queued. Yeah, I saw this about two hours after I sent those emails ... Also, I prefer your commit message! ;-) Thanks. ATB, Ramsay Jones ```