git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Oct 26, 2011, 21:30 UTC
Message-ID
<4EA87C06.8080808@ramsay1.demon.co.uk>
In-Reply-To
<201110260236.59509.jnareb@gmail.com>
Jakub Narebski wrote:
Show 27 quoted lines
> Drew Northup napisał:
>> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
>>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>>> ---
>>>  gitweb/Makefile |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/gitweb/Makefile b/gitweb/Makefile
>>> index 1c85b5f..4191c6b 100644
>>> --- a/gitweb/Makefile
>>> +++ b/gitweb/Makefile
>>> @@ -185,7 +185,9 @@ install: all
>>>  ### Cleaning rules
>>>  
>>>  clean:
>>> -	$(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
>>> +	$(RM) gitweb.cgi static/gitweb.js \
>>> +		static/gitweb.min.js static/gitweb.min.css \
>>> +		GITWEB-BUILD-OPTIONS
>>>  
>>>  .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
>>>  
>> Forgive me for sounding a bit numb, but what does this fix? I don't see
>> it in the commit message.
> 
> gitweb.js is nowadays a generated file.  Though that bit should be
> in commit message...
Yep, will do ...

ATB, Ramsay Jones

Previous: Jakub NarebskiNext: Junio C Hamano
Message 4 of 6 in “gitweb/Makefile: Remove static/gitweb.js in the clean target”
  1. gitweb/Makefile: Remove static/gitweb.js in the clean targetRamsay Jones, Oct 25, 2011
  2. Drew NorthupOct 25, 2011
  3. Jakub NarebskiOct 26, 2011
  4. Ramsay JonesOct 26, 2011
  5. Junio C HamanoOct 27, 2011
  6. Ramsay JonesOct 29, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.