threads / patch / 28728

patchbuiltin/pack-objects.c: Fix a printf format compiler warning

Subject: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

## tl;dr

3 messages between Oct 19, 2011 and Oct 21, 2011. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ramsay Jones· Oct 19, 2011, 19:10 UTC · lore

In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows:

        CC builtin/pack-objects.o
    pack-objects.c: In function `compute_write_order':
    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)

In order to suppress the warning, we use the C99 format specifier macro PRIu32.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Dan,

If you need to re-roll your pack-objects series (dm/pack-objects-update branch in pu), could you please squash this change into your final commit 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).

If you don't need to re-roll, then I'm hoping Junio will notice and squash this in before it hits next. ;-)

ATB, Ramsay Jones

 builtin/pack-objects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to builtin/pack-objects.c +1 −1

diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 6db45fa..4bbd815 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -597,7 +597,7 @@ static struct object_entry **compute_write_order(void)
 	}
 
 	if (wo_end != nr_objects)
-		die("ordered %u objects, expected %u", wo_end, nr_objects);
+		die("ordered %u objects, expected %"PRIu32, wo_end, nr_objects);
 
 	return wo;
 }

-- 
1.7.7

Dan McGee· Oct 20, 2011, 18:54 UTC · re: Ramsay Jones · lore

Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

On Wed, Oct 19, 2011 at 2:10 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 22 quoted lines

>
> In particular, on systems that define uint32_t as an unsigned long,
> gcc complains as follows:
>
>        CC builtin/pack-objects.o
>    pack-objects.c: In function `compute_write_order':
>    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)
>
> In order to suppress the warning, we use the C99 format specifier
> macro PRIu32.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Dan,
>
> If you need to re-roll your pack-objects series (dm/pack-objects-update
> branch in pu), could you please squash this change into your final commit
> 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).
>
> If you don't need to re-roll, then I'm hoping Junio will notice and squash
> this in before it hits next. ;-)

Sorry about that- fixed locally, and if I do need to resend them then it will be fixed.

-Dan

Junio C Hamano· Oct 21, 2011, 00:17 UTC · re: Ramsay Jones · lore

Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:

> If you don't need to re-roll, then I'm hoping Junio will notice and squash
> this in before it hits next. ;-)

Will do; thanks, both.