git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Oct 19, 2011, 19:10 UTC
Message-ID
<4E9F20AD.4020209@ramsay1.demon.co.uk>

In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows:

        CC builtin/pack-objects.o
    pack-objects.c: In function `compute_write_order':
    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)

In order to suppress the warning, we use the C99 format specifier macro PRIu32.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Dan,

If you need to re-roll your pack-objects series (dm/pack-objects-update branch in pu), could you please squash this change into your final commit 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).

If you don't need to re-roll, then I'm hoping Junio will notice and squash this in before it hits next. ;-)

ATB, Ramsay Jones

 builtin/pack-objects.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index 6db45fa..4bbd815 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -597,7 +597,7 @@ static struct object_entry **compute_write_order(void)
 	}
 
 	if (wo_end != nr_objects)
-		die("ordered %u objects, expected %u", wo_end, nr_objects);
+		die("ordered %u objects, expected %"PRIu32, wo_end, nr_objects);
 
 	return wo;
 }
-- 
1.7.7
Next: Dan McGee
Message 1 of 3 in “builtin/pack-objects.c: Fix a printf format compiler warning”
  1. builtin/pack-objects.c: Fix a printf format compiler warningRamsay Jones, Oct 19, 2011
  2. Dan McGeeOct 20, 2011
  3. Junio C HamanoOct 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.