Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning

From: Dan McGee <dpmcgee@gmail.com>
Date: Oct 20, 2011, 18:54 UTC
Message-ID: <CAEik5nNPrxuRfkbniLV96Mfsg_pPDQc_oOsS29Y2+ofoLW+5-A@mail.gmail.com>
In-Reply-To: <4E9F20AD.4020209@ramsay1.demon.co.uk>

On Wed, Oct 19, 2011 at 2:10 PM, Ramsay Jones <ramsay@ramsay1.demon.co.uk> wrote:

Show 22 quoted lines

>
> In particular, on systems that define uint32_t as an unsigned long,
> gcc complains as follows:
>
>        CC builtin/pack-objects.o
>    pack-objects.c: In function `compute_write_order':
>    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)
>
> In order to suppress the warning, we use the C99 format specifier
> macro PRIu32.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Dan,
>
> If you need to re-roll your pack-objects series (dm/pack-objects-update
> branch in pu), could you please squash this change into your final commit
> 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).
>
> If you don't need to re-roll, then I'm hoping Junio will notice and squash
> this in before it hits next. ;-)

Sorry about that- fixed locally, and if I do need to resend them then it will be fixed.

-Dan