{"thread":{"id":"28728","subject":"[PATCH] builtin/pack-objects.c: Fix a printf format compiler warning","startedAt":"2011-10-19T19:10:37Z","lastAt":"2011-10-21T00:17:31Z","messageCount":3,"participants":["Ramsay Jones","Dan McGee","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"178093","messageId":"4E9F20AD.4020209@ramsay1.demon.co.uk","threadId":"28728","inReplyTo":null,"subject":"[PATCH] builtin/pack-objects.c: Fix a printf format compiler warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-10-19T19:10:37Z","receivedAt":"2011-10-19T19:10:37Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, on systems that define uint32_t as an unsigned long,\ngcc complains as follows:\n\n        CC builtin/pack-objects.o\n    pack-objects.c: In function `compute_write_order':\n    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)\n\nIn order to suppress the warning, we use the C99 format specifier\nmacro PRIu32.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Dan,\n\nIf you need to re-roll your pack-objects series (dm/pack-objects-update\nbranch in pu), could you please squash this change into your final commit\n0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).\n\nIf you don't need to re-roll, then I'm hoping Junio will notice and squash\nthis in before it hits next. ;-)\n\nATB,\nRamsay Jones\n\n builtin/pack-objects.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin/pack-objects.c b/builtin/pack-objects.c\nindex 6db45fa..4bbd815 100644\n--- a/builtin/pack-objects.c\n+++ b/builtin/pack-objects.c\n@@ -597,7 +597,7 @@ static struct object_entry **compute_write_order(void)\n \t}\n \n \tif (wo_end != nr_objects)\n-\t\tdie(\"ordered %u objects, expected %u\", wo_end, nr_objects);\n+\t\tdie(\"ordered %u objects, expected %\"PRIu32, wo_end, nr_objects);\n \n \treturn wo;\n }\n-- \n1.7.7\n"},{"id":"178097","messageId":"CAEik5nNPrxuRfkbniLV96Mfsg_pPDQc_oOsS29Y2+ofoLW+5-A@mail.gmail.com","threadId":"28728","inReplyTo":"4E9F20AD.4020209@ramsay1.demon.co.uk","subject":"Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning","fromName":"Dan McGee","fromEmail":"dpmcgee@gmail.com","sentAt":"2011-10-20T18:54:23Z","receivedAt":"2011-10-20T18:54:23Z","isPatch":true,"sender":{"key":"dpmcgee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/265817?v=4"},"body":"On Wed, Oct 19, 2011 at 2:10 PM, Ramsay Jones\n<ramsay@ramsay1.demon.co.uk> wrote:\n>\n> In particular, on systems that define uint32_t as an unsigned long,\n> gcc complains as follows:\n>\n>        CC builtin/pack-objects.o\n>    pack-objects.c: In function `compute_write_order':\n>    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3)\n>\n> In order to suppress the warning, we use the C99 format specifier\n> macro PRIu32.\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Dan,\n>\n> If you need to re-roll your pack-objects series (dm/pack-objects-update\n> branch in pu), could you please squash this change into your final commit\n> 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011).\n>\n> If you don't need to re-roll, then I'm hoping Junio will notice and squash\n> this in before it hits next. ;-)\nSorry about that- fixed locally, and if I do need to resend them then\nit will be fixed.\n\n-Dan\n"},{"id":"178108","messageId":"7vr5278ag4.fsf@alter.siamese.dyndns.org","threadId":"28728","inReplyTo":"4E9F20AD.4020209@ramsay1.demon.co.uk","subject":"Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2011-10-21T00:17:31Z","receivedAt":"2011-10-21T00:17:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:\n\n> If you don't need to re-roll, then I'm hoping Junio will notice and squash\n> this in before it hits next. ;-)\n\nWill do; thanks, both.\n"}]}