# [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning 3 messages from 2011-10-19 to 2011-10-21. Participants: Ramsay Jones, Dan McGee, Junio C Hamano. Thread: https://gitlist.dev/t/28728 ## Ramsay Jones, 2011-10-19 19:10 Subject: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning Message-ID: <4E9F20AD.4020209@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4E9F20AD.4020209%40ramsay1.demon.co.uk ``` In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows: CC builtin/pack-objects.o pack-objects.c: In function `compute_write_order': pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3) In order to suppress the warning, we use the C99 format specifier macro PRIu32. Signed-off-by: Ramsay Jones --- Hi Dan, If you need to re-roll your pack-objects series (dm/pack-objects-update branch in pu), could you please squash this change into your final commit 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011). If you don't need to re-roll, then I'm hoping Junio will notice and squash this in before it hits next. ;-) ATB, Ramsay Jones builtin/pack-objects.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 6db45fa..4bbd815 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -597,7 +597,7 @@ static struct object_entry **compute_write_order(void) } if (wo_end != nr_objects) - die("ordered %u objects, expected %u", wo_end, nr_objects); + die("ordered %u objects, expected %"PRIu32, wo_end, nr_objects); return wo; } -- 1.7.7 ``` ## Dan McGee, 2011-10-20 18:54 Subject: Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning Message-ID: URL: https://gitlist.dev/e/CAEik5nNPrxuRfkbniLV96Mfsg_pPDQc_oOsS29Y2%2BofoLW%2B5-A%40mail.gmail.com In-Reply-To: <4E9F20AD.4020209@ramsay1.demon.co.uk> ``` On Wed, Oct 19, 2011 at 2:10 PM, Ramsay Jones wrote: > > In particular, on systems that define uint32_t as an unsigned long, > gcc complains as follows: > >        CC builtin/pack-objects.o >    pack-objects.c: In function `compute_write_order': >    pack-objects.c:600: warning: unsigned int format, uint32_t arg (arg 3) > > In order to suppress the warning, we use the C99 format specifier > macro PRIu32. > > Signed-off-by: Ramsay Jones > --- > > Hi Dan, > > If you need to re-roll your pack-objects series (dm/pack-objects-update > branch in pu), could you please squash this change into your final commit > 0a8145bd (pack-objects: don't traverse objects unnecessarily, 18-10-2011). > > If you don't need to re-roll, then I'm hoping Junio will notice and squash > this in before it hits next. ;-) Sorry about that- fixed locally, and if I do need to resend them then it will be fixed. -Dan ``` ## Junio C Hamano, 2011-10-21 00:17 Subject: Re: [PATCH] builtin/pack-objects.c: Fix a printf format compiler warning Message-ID: <7vr5278ag4.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7vr5278ag4.fsf%40alter.siamese.dyndns.org In-Reply-To: <4E9F20AD.4020209@ramsay1.demon.co.uk> ``` Ramsay Jones writes: > If you don't need to re-roll, then I'm hoping Junio will notice and squash > this in before it hits next. ;-) Will do; thanks, both. ```