threads / patch / 26260

patchsvndump.c: Fix a printf format compiler warning

Subject: [PATCH] svndump.c: Fix a printf format compiler warning

## tl;dr

3 messages between Jan 11, 2011 and Jan 15, 2011. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Ramsay Jones· Jan 11, 2011, 18:17 UTC · lore

In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows:

        CC vcs-svn/svndump.o
    vcs-svn/svndump.c: In function `svndump_read':
    vcs-svn/svndump.c:215: warning: int format, uint32_t arg (arg 2)

In order to suppress the warning we use the C99 format specifier macro PRIu32 from <inttypes.h>.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
 vcs-svn/svndump.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to vcs-svn/svndump.c +1 −1

diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
index fa580e6..2ad2c30 100644
--- a/vcs-svn/svndump.c
+++ b/vcs-svn/svndump.c
@@ -211,7 +211,7 @@ void svndump_read(const char *url)
 		if (key == keys.svn_fs_dump_format_version) {
 			dump_ctx.version = atoi(val);
 			if (dump_ctx.version > 2)
-				die("expected svn dump format version <= 2, found %d",
+				die("expected svn dump format version <= 2, found %"PRIu32,
 				    dump_ctx.version);
 		} else if (key == keys.uuid) {
 			dump_ctx.uuid = pool_intern(val);

-- 
1.7.3

Jonathan Nieder· Jan 11, 2011, 18:39 UTC · re: Ramsay Jones · lore

Re: [PATCH] svndump.c: Fix a printf format compiler warning

Ramsay Jones wrote:

Show 9 quoted lines

> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>  		if (key == keys.svn_fs_dump_format_version) {
>  			dump_ctx.version = atoi(val);
>  			if (dump_ctx.version > 2)
> -				die("expected svn dump format version <= 2, found %d",
> +				die("expected svn dump format version <= 2, found %"PRIu32,
>  				    dump_ctx.version);

Acked-by: Jonathan Nieder <jrnieder@gmail.com>

I think we should just use "int", but that is a wider sweeping change for another time. Thanks.

Does gcc or sparse provide a warning that could have caught this mistake?

Ramsay Jones· Jan 15, 2011, 18:06 UTC · re: Jonathan Nieder · lore

Re: [PATCH] svndump.c: Fix a printf format compiler warning

Jonathan Nieder wrote:

Show 13 quoted lines

> Ramsay Jones wrote:
> 
>> --- a/vcs-svn/svndump.c
>> +++ b/vcs-svn/svndump.c
>> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>>  		if (key == keys.svn_fs_dump_format_version) {
>>  			dump_ctx.version = atoi(val);
>>  			if (dump_ctx.version > 2)
>> -				die("expected svn dump format version <= 2, found %d",
>> +				die("expected svn dump format version <= 2, found %"PRIu32,
>>  				    dump_ctx.version);
> 
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks!

Show 5 quoted lines

> I think we should just use "int", but that is a wider sweeping change
> for another time.  Thanks.
> 
> Does gcc or sparse provide a warning that could have caught this
> mistake?

None that I know of, no ... :(

ATB, Ramsay Jones