git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] svndump.c: Fix a printf format compiler warning

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Jan 11, 2011, 18:39 UTC
Message-ID
<20110111183927.GF15133@burratino>
In-Reply-To
<4D2C9EB1.2050100@ramsay1.demon.co.uk>
Ramsay Jones wrote:
Show 9 quoted lines
> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>  		if (key == keys.svn_fs_dump_format_version) {
>  			dump_ctx.version = atoi(val);
>  			if (dump_ctx.version > 2)
> -				die("expected svn dump format version <= 2, found %d",
> +				die("expected svn dump format version <= 2, found %"PRIu32,
>  				    dump_ctx.version);
Acked-by: Jonathan Nieder <jrnieder@gmail.com>

I think we should just use "int", but that is a wider sweeping change for another time. Thanks.

Does gcc or sparse provide a warning that could have caught this mistake?

Previous: Ramsay JonesNext: Ramsay Jones
Message 2 of 3 in “svndump.c: Fix a printf format compiler warning”
  1. svndump.c: Fix a printf format compiler warningRamsay Jones, Jan 11, 2011
  2. Jonathan NiederJan 11, 2011
  3. Ramsay JonesJan 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.