{"thread":{"id":"26260","subject":"[PATCH] svndump.c: Fix a printf format compiler warning","startedAt":"2011-01-11T18:17:21Z","lastAt":"2011-01-15T18:06:27Z","messageCount":3,"participants":["Ramsay Jones","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"159358","messageId":"4D2C9EB1.2050100@ramsay1.demon.co.uk","threadId":"26260","inReplyTo":null,"subject":"[PATCH] svndump.c: Fix a printf format compiler warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-01-11T18:17:21Z","receivedAt":"2011-01-11T18:17:21Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIn particular, on systems that define uint32_t as an unsigned long,\ngcc complains as follows:\n\n        CC vcs-svn/svndump.o\n    vcs-svn/svndump.c: In function `svndump_read':\n    vcs-svn/svndump.c:215: warning: int format, uint32_t arg (arg 2)\n\nIn order to suppress the warning we use the C99 format specifier\nmacro PRIu32 from <inttypes.h>.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n vcs-svn/svndump.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c\nindex fa580e6..2ad2c30 100644\n--- a/vcs-svn/svndump.c\n+++ b/vcs-svn/svndump.c\n@@ -211,7 +211,7 @@ void svndump_read(const char *url)\n \t\tif (key == keys.svn_fs_dump_format_version) {\n \t\t\tdump_ctx.version = atoi(val);\n \t\t\tif (dump_ctx.version > 2)\n-\t\t\t\tdie(\"expected svn dump format version <= 2, found %d\",\n+\t\t\t\tdie(\"expected svn dump format version <= 2, found %\"PRIu32,\n \t\t\t\t    dump_ctx.version);\n \t\t} else if (key == keys.uuid) {\n \t\t\tdump_ctx.uuid = pool_intern(val);\n-- \n1.7.3\n"},{"id":"159361","messageId":"20110111183927.GF15133@burratino","threadId":"26260","inReplyTo":"4D2C9EB1.2050100@ramsay1.demon.co.uk","subject":"Re: [PATCH] svndump.c: Fix a printf format compiler warning","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2011-01-11T18:39:27Z","receivedAt":"2011-01-11T18:39:27Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Ramsay Jones wrote:\n\n> --- a/vcs-svn/svndump.c\n> +++ b/vcs-svn/svndump.c\n> @@ -211,7 +211,7 @@ void svndump_read(const char *url)\n>  \t\tif (key == keys.svn_fs_dump_format_version) {\n>  \t\t\tdump_ctx.version = atoi(val);\n>  \t\t\tif (dump_ctx.version > 2)\n> -\t\t\t\tdie(\"expected svn dump format version <= 2, found %d\",\n> +\t\t\t\tdie(\"expected svn dump format version <= 2, found %\"PRIu32,\n>  \t\t\t\t    dump_ctx.version);\n\nAcked-by: Jonathan Nieder <jrnieder@gmail.com>\n\nI think we should just use \"int\", but that is a wider sweeping change\nfor another time.  Thanks.\n\nDoes gcc or sparse provide a warning that could have caught this\nmistake?\n"},{"id":"159531","messageId":"4D31E223.3080001@ramsay1.demon.co.uk","threadId":"26260","inReplyTo":"20110111183927.GF15133@burratino","subject":"Re: [PATCH] svndump.c: Fix a printf format compiler warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2011-01-15T18:06:27Z","receivedAt":"2011-01-15T18:06:27Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Jonathan Nieder wrote:\n> Ramsay Jones wrote:\n> \n>> --- a/vcs-svn/svndump.c\n>> +++ b/vcs-svn/svndump.c\n>> @@ -211,7 +211,7 @@ void svndump_read(const char *url)\n>>  \t\tif (key == keys.svn_fs_dump_format_version) {\n>>  \t\t\tdump_ctx.version = atoi(val);\n>>  \t\t\tif (dump_ctx.version > 2)\n>> -\t\t\t\tdie(\"expected svn dump format version <= 2, found %d\",\n>> +\t\t\t\tdie(\"expected svn dump format version <= 2, found %\"PRIu32,\n>>  \t\t\t\t    dump_ctx.version);\n> \n> Acked-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks!\n\n> I think we should just use \"int\", but that is a wider sweeping change\n> for another time.  Thanks.\n> \n> Does gcc or sparse provide a warning that could have caught this\n> mistake?\n\nNone that I know of, no ... :(\n\nATB,\nRamsay Jones\n"}]}