Re: [PATCH] svndump.c: Fix a printf format compiler warning

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Jan 15, 2011, 18:06 UTC
Message-ID: <4D31E223.3080001@ramsay1.demon.co.uk>
In-Reply-To: <20110111183927.GF15133@burratino>

Jonathan Nieder wrote:

Show 13 quoted lines

> Ramsay Jones wrote:
> 
>> --- a/vcs-svn/svndump.c
>> +++ b/vcs-svn/svndump.c
>> @@ -211,7 +211,7 @@ void svndump_read(const char *url)
>>  		if (key == keys.svn_fs_dump_format_version) {
>>  			dump_ctx.version = atoi(val);
>>  			if (dump_ctx.version > 2)
>> -				die("expected svn dump format version <= 2, found %d",
>> +				die("expected svn dump format version <= 2, found %"PRIu32,
>>  				    dump_ctx.version);
> 
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks!

Show 5 quoted lines

> I think we should just use "int", but that is a wider sweeping change
> for another time.  Thanks.
> 
> Does gcc or sparse provide a warning that could have caught this
> mistake?

None that I know of, no ... :(

ATB, Ramsay Jones