# [PATCH] svndump.c: Fix a printf format compiler warning 3 messages from 2011-01-11 to 2011-01-15. Participants: Ramsay Jones, Jonathan Nieder. Thread: https://gitlist.dev/t/26260 ## Ramsay Jones, 2011-01-11 18:17 Subject: [PATCH] svndump.c: Fix a printf format compiler warning Message-ID: <4D2C9EB1.2050100@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4D2C9EB1.2050100%40ramsay1.demon.co.uk ``` In particular, on systems that define uint32_t as an unsigned long, gcc complains as follows: CC vcs-svn/svndump.o vcs-svn/svndump.c: In function `svndump_read': vcs-svn/svndump.c:215: warning: int format, uint32_t arg (arg 2) In order to suppress the warning we use the C99 format specifier macro PRIu32 from . Signed-off-by: Ramsay Jones --- vcs-svn/svndump.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c index fa580e6..2ad2c30 100644 --- a/vcs-svn/svndump.c +++ b/vcs-svn/svndump.c @@ -211,7 +211,7 @@ void svndump_read(const char *url) if (key == keys.svn_fs_dump_format_version) { dump_ctx.version = atoi(val); if (dump_ctx.version > 2) - die("expected svn dump format version <= 2, found %d", + die("expected svn dump format version <= 2, found %"PRIu32, dump_ctx.version); } else if (key == keys.uuid) { dump_ctx.uuid = pool_intern(val); -- 1.7.3 ``` ## Jonathan Nieder, 2011-01-11 18:39 Subject: Re: [PATCH] svndump.c: Fix a printf format compiler warning Message-ID: <20110111183927.GF15133@burratino> URL: https://gitlist.dev/e/20110111183927.GF15133%40burratino In-Reply-To: <4D2C9EB1.2050100@ramsay1.demon.co.uk> ``` Ramsay Jones wrote: > --- a/vcs-svn/svndump.c > +++ b/vcs-svn/svndump.c > @@ -211,7 +211,7 @@ void svndump_read(const char *url) > if (key == keys.svn_fs_dump_format_version) { > dump_ctx.version = atoi(val); > if (dump_ctx.version > 2) > - die("expected svn dump format version <= 2, found %d", > + die("expected svn dump format version <= 2, found %"PRIu32, > dump_ctx.version); Acked-by: Jonathan Nieder I think we should just use "int", but that is a wider sweeping change for another time. Thanks. Does gcc or sparse provide a warning that could have caught this mistake? ``` ## Ramsay Jones, 2011-01-15 18:06 Subject: Re: [PATCH] svndump.c: Fix a printf format compiler warning Message-ID: <4D31E223.3080001@ramsay1.demon.co.uk> URL: https://gitlist.dev/e/4D31E223.3080001%40ramsay1.demon.co.uk In-Reply-To: <20110111183927.GF15133@burratino> ``` Jonathan Nieder wrote: > Ramsay Jones wrote: > >> --- a/vcs-svn/svndump.c >> +++ b/vcs-svn/svndump.c >> @@ -211,7 +211,7 @@ void svndump_read(const char *url) >> if (key == keys.svn_fs_dump_format_version) { >> dump_ctx.version = atoi(val); >> if (dump_ctx.version > 2) >> - die("expected svn dump format version <= 2, found %d", >> + die("expected svn dump format version <= 2, found %"PRIu32, >> dump_ctx.version); > > Acked-by: Jonathan Nieder Thanks! > I think we should just use "int", but that is a wider sweeping change > for another time. Thanks. > > Does gcc or sparse provide a warning that could have caught this > mistake? None that I know of, no ... :( ATB, Ramsay Jones ```