threads / patch / 24557

patchSubmittingPatches: Clarify the Signed-off-by rules

Subject: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules

## tl;dr

3 messages between Jul 28, 2010 and Jul 28, 2010. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Ævar Arnfjörð Bjarmason· Jul 28, 2010, 14:12 UTC · lore

The wording of the Signed-off-by rules could be read as stating that S-O-B should only be added when the submitter considered the patch ready for inclusion in git.git.

We also want Signed-off-by to be used for e.g. RFC patches, in case someone wants to dig an old patch out of the archive and improve it. Change the wording to recommend a Signed-off-by for all submitted patches.

The problem with the wording came up in the "[PATCH/RFC] Hacky version of a glob() driven config include" thread[1]. Bert Wesarg suggested[2] that it be removed to avoid confusion, which this change implements.

  1. <1273180440-8641-1-git-send-email-avarab@gmail.com>
  2. <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com>

Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Documentation/SubmittingPatches |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

Show changes to Documentation/SubmittingPatches +3 −5

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 099b238..ece3c77 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -14,11 +14,9 @@ Checklist (and a short version for the impatient):
 		  not "changed" or "changes".
 		- includes motivation for the change, and contrasts
 		  its implementation with previous behaviour
-	- if you want your work included in git.git, add a
-	  "Signed-off-by: Your Name <you@example.com>" line to the
-	  commit message (or just use the option "-s" when
-	  committing) to confirm that you agree to the Developer's
-	  Certificate of Origin
+	- add a "Signed-off-by: Your Name <you@example.com>" line to the
+	  commit message (or just use the option "-s" when committing)
+	  to confirm that you agree to the Developer's Certificate of Origin
 	- make sure that you have tests for the bug you are fixing
 	- make sure that the test suite passes after your commit

-- 
1.7.0.4

Junio C Hamano· Jul 28, 2010, 17:23 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 8 quoted lines

> The wording of the Signed-off-by rules could be read as stating that
> S-O-B should only be added when the submitter considered the patch
> ready for inclusion in git.git.
>
> We also want Signed-off-by to be used for e.g. RFC patches, in case
> someone wants to dig an old patch out of the archive and improve
> it. Change the wording to recommend a Signed-off-by for all submitted
> patches.

Ok. In the past, some people (including Linus) used the lack of sign-off as a hint to say it is not meant for inclusion, but I always considered it a bad practice ("RFC" or whatever word next to "PATCH" in bracket would be far more descriptive). I think this is a good change.

Thanks.

Bert Wesarg· Jul 28, 2010, 17:23 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules

On Wed, Jul 28, 2010 at 16:12, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

> The wording of the Signed-off-by rules could be read as stating that
> S-O-B should only be added when the submitter considered the patch
> ready for inclusion in git.git.
>
> We also want Signed-off-by to be used for e.g. RFC patches, in case
> someone wants to dig an old patch out of the archive and improve
> it. Change the wording to recommend a Signed-off-by for all submitted
> patches.
>
> The problem with the wording came up in the "[PATCH/RFC] Hacky version
> of a glob() driven config include" thread[1]. Bert Wesarg suggested[2]
> that it be removed to avoid confusion, which this change implements.
>

Thanks for resurrecting this.

Acked-by: Bert Wesarg <bert.wesarg@googlemail.com>

Show 32 quoted lines

>  1. <1273180440-8641-1-git-send-email-avarab@gmail.com>
>  2. <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com>
>
> Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Documentation/SubmittingPatches |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 099b238..ece3c77 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -14,11 +14,9 @@ Checklist (and a short version for the impatient):
>                  not "changed" or "changes".
>                - includes motivation for the change, and contrasts
>                  its implementation with previous behaviour
> -       - if you want your work included in git.git, add a
> -         "Signed-off-by: Your Name <you@example.com>" line to the
> -         commit message (or just use the option "-s" when
> -         committing) to confirm that you agree to the Developer's
> -         Certificate of Origin
> +       - add a "Signed-off-by: Your Name <you@example.com>" line to the
> +         commit message (or just use the option "-s" when committing)
> +         to confirm that you agree to the Developer's Certificate of Origin
>        - make sure that you have tests for the bug you are fixing
>        - make sure that the test suite passes after your commit
>
> --
> 1.7.0.4
>
>