{"thread":{"id":"24557","subject":"[PATCH] SubmittingPatches: Clarify the Signed-off-by rules","startedAt":"2010-07-28T14:12:59Z","lastAt":"2010-07-28T17:23:25Z","messageCount":3,"participants":["Ævar Arnfjörð Bjarmason","Bert Wesarg","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"146626","messageId":"1280326379-10257-1-git-send-email-avarab@gmail.com","threadId":"24557","inReplyTo":null,"subject":"[PATCH] SubmittingPatches: Clarify the Signed-off-by rules","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2010-07-28T14:12:59Z","receivedAt":"2010-07-28T14:12:59Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"The wording of the Signed-off-by rules could be read as stating that\nS-O-B should only be added when the submitter considered the patch\nready for inclusion in git.git.\n\nWe also want Signed-off-by to be used for e.g. RFC patches, in case\nsomeone wants to dig an old patch out of the archive and improve\nit. Change the wording to recommend a Signed-off-by for all submitted\npatches.\n\nThe problem with the wording came up in the \"[PATCH/RFC] Hacky version\nof a glob() driven config include\" thread[1]. Bert Wesarg suggested[2]\nthat it be removed to avoid confusion, which this change implements.\n\n 1. <1273180440-8641-1-git-send-email-avarab@gmail.com>\n 2. \n\nSuggested-by: Bert Wesarg \nSigned-off-by: Ævar Arnfjörð Bjarmason \n---\n Documentation/SubmittingPatches | 8 +++-----\n 1 files changed, 3 insertions(+), 5 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex 099b238..ece3c77 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -14,11 +14,9 @@ Checklist (and a short version for the impatient):\n \t\t not \"changed\" or \"changes\".\n \t\t- includes motivation for the change, and contrasts\n \t\t its implementation with previous behaviour\n-\t- if you want your work included in git.git, add a\n-\t \"Signed-off-by: Your Name \" line to the\n-\t commit message (or just use the option \"-s\" when\n-\t committing) to confirm that you agree to the Developer's\n-\t Certificate of Origin\n+\t- add a \"Signed-off-by: Your Name \" line to the\n+\t commit message (or just use the option \"-s\" when committing)\n+\t to confirm that you agree to the Developer's Certificate of Origin\n \t- make sure that you have tests for the bug you are fixing\n \t- make sure that the test suite passes after your commit\n \n-- \n1.7.0.4\n"},{"id":"146643","messageId":"7v62zz5xmj.fsf@alter.siamese.dyndns.org","threadId":"24557","inReplyTo":"1280326379-10257-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2010-07-28T17:23:16Z","receivedAt":"2010-07-28T17:23:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ævar Arnfjörð Bjarmason writes:\n\n> The wording of the Signed-off-by rules could be read as stating that\n> S-O-B should only be added when the submitter considered the patch\n> ready for inclusion in git.git.\n>\n> We also want Signed-off-by to be used for e.g. RFC patches, in case\n> someone wants to dig an old patch out of the archive and improve\n> it. Change the wording to recommend a Signed-off-by for all submitted\n> patches.\n\nOk. In the past, some people (including Linus) used the lack of sign-off\nas a hint to say it is not meant for inclusion, but I always considered it\na bad practice (\"RFC\" or whatever word next to \"PATCH\" in bracket would be\nfar more descriptive). I think this is a good change.\n\nThanks.\n"},{"id":"146641","messageId":"AANLkTi=wT_-1dq-TEb=XNLnh9BM_q4krArwfR8NV+eSk@mail.gmail.com","threadId":"24557","inReplyTo":"1280326379-10257-1-git-send-email-avarab@gmail.com","subject":"Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules","fromName":"Bert Wesarg","fromEmail":"bert.wesarg@googlemail.com","sentAt":"2010-07-28T17:23:25Z","receivedAt":"2010-07-28T17:23:25Z","isPatch":true,"sender":{"key":"bert.wesarg@googlemail.com","avatar":"https://avatars.githubusercontent.com/u/111934?v=4"},"body":"On Wed, Jul 28, 2010 at 16:12, Ævar Arnfjörð Bjarmason wrote:\n> The wording of the Signed-off-by rules could be read as stating that\n> S-O-B should only be added when the submitter considered the patch\n> ready for inclusion in git.git.\n>\n> We also want Signed-off-by to be used for e.g. RFC patches, in case\n> someone wants to dig an old patch out of the archive and improve\n> it. Change the wording to recommend a Signed-off-by for all submitted\n> patches.\n>\n> The problem with the wording came up in the \"[PATCH/RFC] Hacky version\n> of a glob() driven config include\" thread[1]. Bert Wesarg suggested[2]\n> that it be removed to avoid confusion, which this change implements.\n>\n\nThanks for resurrecting this.\n\nAcked-by: Bert Wesarg \n\n>  1. <1273180440-8641-1-git-send-email-avarab@gmail.com>\n>  2. \n>\n> Suggested-by: Bert Wesarg \n> Signed-off-by: Ævar Arnfjörð Bjarmason \n> ---\n>  Documentation/SubmittingPatches |    8 +++-----\n>  1 files changed, 3 insertions(+), 5 deletions(-)\n>\n> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n> index 099b238..ece3c77 100644\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -14,11 +14,9 @@ Checklist (and a short version for the impatient):\n>                  not \"changed\" or \"changes\".\n>                - includes motivation for the change, and contrasts\n>                  its implementation with previous behaviour\n> -       - if you want your work included in git.git, add a\n> -         \"Signed-off-by: Your Name \" line to the\n> -         commit message (or just use the option \"-s\" when\n> -         committing) to confirm that you agree to the Developer's\n> -         Certificate of Origin\n> +       - add a \"Signed-off-by: Your Name \" line to the\n> +         commit message (or just use the option \"-s\" when committing)\n> +         to confirm that you agree to the Developer's Certificate of Origin\n>        - make sure that you have tests for the bug you are fixing\n>        - make sure that the test suite passes after your commit\n>\n> --\n> 1.7.0.4\n>\n>\n"}]}