Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 28, 2010, 17:23 UTC
- Message-ID
- <7v62zz5xmj.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1280326379-10257-1-git-send-email-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 8 quoted lines
> The wording of the Signed-off-by rules could be read as stating that > S-O-B should only be added when the submitter considered the patch > ready for inclusion in git.git. > > We also want Signed-off-by to be used for e.g. RFC patches, in case > someone wants to dig an old patch out of the archive and improve > it. Change the wording to recommend a Signed-off-by for all submitted > patches.
Ok. In the past, some people (including Linus) used the lack of sign-off as a hint to say it is not meant for inclusion, but I always considered it a bad practice ("RFC" or whatever word next to "PATCH" in bracket would be far more descriptive). I think this is a good change.
Thanks.