Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Jul 28, 2010, 17:23 UTC
Message-ID: <AANLkTi=wT_-1dq-TEb=XNLnh9BM_q4krArwfR8NV+eSk@mail.gmail.com>
In-Reply-To: <1280326379-10257-1-git-send-email-avarab@gmail.com>

On Wed, Jul 28, 2010 at 16:12, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 13 quoted lines

> The wording of the Signed-off-by rules could be read as stating that
> S-O-B should only be added when the submitter considered the patch
> ready for inclusion in git.git.
>
> We also want Signed-off-by to be used for e.g. RFC patches, in case
> someone wants to dig an old patch out of the archive and improve
> it. Change the wording to recommend a Signed-off-by for all submitted
> patches.
>
> The problem with the wording came up in the "[PATCH/RFC] Hacky version
> of a glob() driven config include" thread[1]. Bert Wesarg suggested[2]
> that it be removed to avoid confusion, which this change implements.
>

Thanks for resurrecting this.

Acked-by: Bert Wesarg <bert.wesarg@googlemail.com>

Show 32 quoted lines

>  1. <1273180440-8641-1-git-send-email-avarab@gmail.com>
>  2. <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com>
>
> Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Documentation/SubmittingPatches |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 099b238..ece3c77 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -14,11 +14,9 @@ Checklist (and a short version for the impatient):
>                  not "changed" or "changes".
>                - includes motivation for the change, and contrasts
>                  its implementation with previous behaviour
> -       - if you want your work included in git.git, add a
> -         "Signed-off-by: Your Name <you@example.com>" line to the
> -         commit message (or just use the option "-s" when
> -         committing) to confirm that you agree to the Developer's
> -         Certificate of Origin
> +       - add a "Signed-off-by: Your Name <you@example.com>" line to the
> +         commit message (or just use the option "-s" when committing)
> +         to confirm that you agree to the Developer's Certificate of Origin
>        - make sure that you have tests for the bug you are fixing
>        - make sure that the test suite passes after your commit
>
> --
> 1.7.0.4
>
>