# [PATCH] SubmittingPatches: Clarify the Signed-off-by rules 3 messages from 2010-07-28 to 2010-07-28. Participants: Ævar Arnfjörð Bjarmason, Bert Wesarg, Junio C Hamano. Thread: https://gitlist.dev/t/24557 ## Ævar Arnfjörð Bjarmason, 2010-07-28 14:12 Subject: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules Message-ID: <1280326379-10257-1-git-send-email-avarab@gmail.com> URL: https://gitlist.dev/e/1280326379-10257-1-git-send-email-avarab%40gmail.com ``` The wording of the Signed-off-by rules could be read as stating that S-O-B should only be added when the submitter considered the patch ready for inclusion in git.git. We also want Signed-off-by to be used for e.g. RFC patches, in case someone wants to dig an old patch out of the archive and improve it. Change the wording to recommend a Signed-off-by for all submitted patches. The problem with the wording came up in the "[PATCH/RFC] Hacky version of a glob() driven config include" thread[1]. Bert Wesarg suggested[2] that it be removed to avoid confusion, which this change implements. 1. <1273180440-8641-1-git-send-email-avarab@gmail.com> 2. Suggested-by: Bert Wesarg Signed-off-by: Ævar Arnfjörð Bjarmason --- Documentation/SubmittingPatches | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 099b238..ece3c77 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -14,11 +14,9 @@ Checklist (and a short version for the impatient): not "changed" or "changes". - includes motivation for the change, and contrasts its implementation with previous behaviour - - if you want your work included in git.git, add a - "Signed-off-by: Your Name " line to the - commit message (or just use the option "-s" when - committing) to confirm that you agree to the Developer's - Certificate of Origin + - add a "Signed-off-by: Your Name " line to the + commit message (or just use the option "-s" when committing) + to confirm that you agree to the Developer's Certificate of Origin - make sure that you have tests for the bug you are fixing - make sure that the test suite passes after your commit -- 1.7.0.4 ``` ## Junio C Hamano, 2010-07-28 17:23 Subject: Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules Message-ID: <7v62zz5xmj.fsf@alter.siamese.dyndns.org> URL: https://gitlist.dev/e/7v62zz5xmj.fsf%40alter.siamese.dyndns.org In-Reply-To: <1280326379-10257-1-git-send-email-avarab@gmail.com> ``` Ævar Arnfjörð Bjarmason writes: > The wording of the Signed-off-by rules could be read as stating that > S-O-B should only be added when the submitter considered the patch > ready for inclusion in git.git. > > We also want Signed-off-by to be used for e.g. RFC patches, in case > someone wants to dig an old patch out of the archive and improve > it. Change the wording to recommend a Signed-off-by for all submitted > patches. Ok. In the past, some people (including Linus) used the lack of sign-off as a hint to say it is not meant for inclusion, but I always considered it a bad practice ("RFC" or whatever word next to "PATCH" in bracket would be far more descriptive). I think this is a good change. Thanks. ``` ## Bert Wesarg, 2010-07-28 17:23 Subject: Re: [PATCH] SubmittingPatches: Clarify the Signed-off-by rules Message-ID: URL: https://gitlist.dev/e/AANLkTi%3DwT_-1dq-TEb%3DXNLnh9BM_q4krArwfR8NV%2BeSk%40mail.gmail.com In-Reply-To: <1280326379-10257-1-git-send-email-avarab@gmail.com> ``` On Wed, Jul 28, 2010 at 16:12, Ævar Arnfjörð Bjarmason wrote: > The wording of the Signed-off-by rules could be read as stating that > S-O-B should only be added when the submitter considered the patch > ready for inclusion in git.git. > > We also want Signed-off-by to be used for e.g. RFC patches, in case > someone wants to dig an old patch out of the archive and improve > it. Change the wording to recommend a Signed-off-by for all submitted > patches. > > The problem with the wording came up in the "[PATCH/RFC] Hacky version > of a glob() driven config include" thread[1]. Bert Wesarg suggested[2] > that it be removed to avoid confusion, which this change implements. > Thanks for resurrecting this. Acked-by: Bert Wesarg >  1. <1273180440-8641-1-git-send-email-avarab@gmail.com> >  2. > > Suggested-by: Bert Wesarg > Signed-off-by: Ævar Arnfjörð Bjarmason > --- >  Documentation/SubmittingPatches |    8 +++----- >  1 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 099b238..ece3c77 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -14,11 +14,9 @@ Checklist (and a short version for the impatient): >                  not "changed" or "changes". >                - includes motivation for the change, and contrasts >                  its implementation with previous behaviour > -       - if you want your work included in git.git, add a > -         "Signed-off-by: Your Name " line to the > -         commit message (or just use the option "-s" when > -         committing) to confirm that you agree to the Developer's > -         Certificate of Origin > +       - add a "Signed-off-by: Your Name " line to the > +         commit message (or just use the option "-s" when committing) > +         to confirm that you agree to the Developer's Certificate of Origin >        - make sure that you have tests for the bug you are fixing >        - make sure that the test suite passes after your commit > > -- > 1.7.0.4 > > ```