threads / patch / 22741

patchgit-gui: fix usage of themed widgets variable

Subject: [PATCH] git-gui: fix usage of themed widgets variable

## tl;dr

3 messages between Feb 20, 2010 and Feb 20, 2010. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Heiko Voigt· Feb 20, 2010, 18:01 UTC · lore

There was one forgotten global so NS was not visible to the method which resulted in an error.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to git-gui/lib/status_bar.tcl +1 −0

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c

-- 
1.7.0.m5.rc2.13.g7abfa.dirty

Pat Thoyts· Feb 20, 2010, 18:47 UTC · re: Heiko Voigt · lore

Re: [PATCH] git-gui: fix usage of themed widgets variable

On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:

Show 22 quoted lines

> There was one forgotten global so NS was not visible to the method
> which resulted in an error.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
>  git-gui/lib/status_bar.tcl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
> index 5fe3aad..95cb449 100644
> --- a/git-gui/lib/status_bar.tcl
> +++ b/git-gui/lib/status_bar.tcl
> @@ -39,6 +39,7 @@ method _oneline_pack {} {
>  }
>
>  constructor two_line {path} {
> +       global NS
>        set w $path
>        set w_l $w.l
>        set w_c $w.c
> --
> 1.7.0.m5.rc2.13.g7abfa.dirty

The commit message should mention what triggered the error I think - but this patch is clearly correct. You can have a

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>

if you like :)

Pat Thoyts.

Heiko Voigt· Feb 20, 2010, 18:57 UTC · re: Pat Thoyts · lore

[PATCH v2] git-gui: fix usage of themed widgets variable

There was one forgotten global so NS was not visible to the method which resulted in an error.

The error was triggered by using git gui to clone a local repository.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:

Show 5 quoted lines

> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>

[...]

Show 8 quoted lines

> 
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> 
> if you like :)

Thanks, taken.

 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to git-gui/lib/status_bar.tcl +1 −0

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c

-- 
1.7.0.m5.rc2.13.g7abfa.dirty