git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] git-gui: fix usage of themed widgets variable

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Feb 20, 2010, 18:57 UTC
Message-ID
<20100220185757.GH15561@book.hvoigt.net>
In-Reply-To
<a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com>

There was one forgotten global so NS was not visible to the method which resulted in an error.

The error was triggered by using git gui to clone a local repository.
Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:
Show 5 quoted lines
> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
[...]
Show 8 quoted lines
> 
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> 
> if you like :)
Thanks, taken.
 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c
-- 
1.7.0.m5.rc2.13.g7abfa.dirty
Previous: Pat Thoyts
Message 3 of 3 in “git-gui: fix usage of themed widgets variable”
  1. git-gui: fix usage of themed widgets variableHeiko Voigt, Feb 20, 2010
  2. Pat ThoytsFeb 20, 2010
  3. git-gui: fix usage of themed widgets variableHeiko Voigt, Feb 20, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.