# [PATCH] git-gui: fix usage of themed widgets variable

3 messages from 2010-02-20 to 2010-02-20. Participants: Heiko Voigt, Pat Thoyts.
Thread: https://gitlist.dev/t/22741

## Heiko Voigt, 2010-02-20 18:01

Subject: [PATCH] git-gui: fix usage of themed widgets variable
Message-ID: <20100220180114.GB15561@book.hvoigt.net>
URL: https://gitlist.dev/e/20100220180114.GB15561%40book.hvoigt.net

```
There was one forgotten global so NS was not visible to the method
which resulted in an error.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c
-- 
1.7.0.m5.rc2.13.g7abfa.dirty

```

## Pat Thoyts, 2010-02-20 18:47

Subject: Re: [PATCH] git-gui: fix usage of themed widgets variable
Message-ID: <a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com>
URL: https://gitlist.dev/e/a5b261831002201047r153a067btb7d2a9cf96617df4%40mail.gmail.com
In-Reply-To: <20100220180114.GB15561@book.hvoigt.net>

```
On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> There was one forgotten global so NS was not visible to the method
> which resulted in an error.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
>  git-gui/lib/status_bar.tcl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
> index 5fe3aad..95cb449 100644
> --- a/git-gui/lib/status_bar.tcl
> +++ b/git-gui/lib/status_bar.tcl
> @@ -39,6 +39,7 @@ method _oneline_pack {} {
>  }
>
>  constructor two_line {path} {
> +       global NS
>        set w $path
>        set w_l $w.l
>        set w_c $w.c
> --
> 1.7.0.m5.rc2.13.g7abfa.dirty

The commit message should mention what triggered the error I think -
but this patch is clearly correct.
You can have a

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>

if you like :)

Pat Thoyts.

```

## Heiko Voigt, 2010-02-20 18:57

Subject: [PATCH v2] git-gui: fix usage of themed widgets variable
Message-ID: <20100220185757.GH15561@book.hvoigt.net>
URL: https://gitlist.dev/e/20100220185757.GH15561%40book.hvoigt.net
In-Reply-To: <a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com>

```
There was one forgotten global so NS was not visible to the method
which resulted in an error.

The error was triggered by using git gui to clone a local repository.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
---
On Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:
> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > There was one forgotten global so NS was not visible to the method
> > which resulted in an error.
> >
> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
[...]
> 
> The commit message should mention what triggered the error I think -
> but this patch is clearly correct.
> You can have a
> 
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> 
> if you like :)

Thanks, taken.

 git-gui/lib/status_bar.tcl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
index 5fe3aad..95cb449 100644
--- a/git-gui/lib/status_bar.tcl
+++ b/git-gui/lib/status_bar.tcl
@@ -39,6 +39,7 @@ method _oneline_pack {} {
 }
 
 constructor two_line {path} {
+	global NS
 	set w $path
 	set w_l $w.l
 	set w_c $w.c
-- 
1.7.0.m5.rc2.13.g7abfa.dirty

```