Re: [PATCH] git-gui: fix usage of themed widgets variable

From: Pat Thoyts <patthoyts@googlemail.com>
Date: Feb 20, 2010, 18:47 UTC
Message-ID: <a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com>
In-Reply-To: <20100220180114.GB15561@book.hvoigt.net>

On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:

Show 22 quoted lines

> There was one forgotten global so NS was not visible to the method
> which resulted in an error.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> ---
>  git-gui/lib/status_bar.tcl |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
> index 5fe3aad..95cb449 100644
> --- a/git-gui/lib/status_bar.tcl
> +++ b/git-gui/lib/status_bar.tcl
> @@ -39,6 +39,7 @@ method _oneline_pack {} {
>  }
>
>  constructor two_line {path} {
> +       global NS
>        set w $path
>        set w_l $w.l
>        set w_c $w.c
> --
> 1.7.0.m5.rc2.13.g7abfa.dirty

The commit message should mention what triggered the error I think - but this patch is clearly correct. You can have a

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>

if you like :)

Pat Thoyts.