{"thread":{"id":"22741","subject":"[PATCH] git-gui: fix usage of themed widgets variable","startedAt":"2010-02-20T18:01:15Z","lastAt":"2010-02-20T18:57:57Z","messageCount":3,"participants":["Heiko Voigt","Pat Thoyts"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"135165","messageId":"20100220180114.GB15561@book.hvoigt.net","threadId":"22741","inReplyTo":null,"subject":"[PATCH] git-gui: fix usage of themed widgets variable","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-20T18:01:15Z","receivedAt":"2010-02-20T18:01:15Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"There was one forgotten global so NS was not visible to the method\nwhich resulted in an error.\n\nSigned-off-by: Heiko Voigt <hvoigt@hvoigt.net>\n---\n git-gui/lib/status_bar.tcl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl\nindex 5fe3aad..95cb449 100644\n--- a/git-gui/lib/status_bar.tcl\n+++ b/git-gui/lib/status_bar.tcl\n@@ -39,6 +39,7 @@ method _oneline_pack {} {\n }\n \n constructor two_line {path} {\n+\tglobal NS\n \tset w $path\n \tset w_l $w.l\n \tset w_c $w.c\n-- \n1.7.0.m5.rc2.13.g7abfa.dirty\n"},{"id":"135173","messageId":"a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com","threadId":"22741","inReplyTo":"20100220180114.GB15561@book.hvoigt.net","subject":"Re: [PATCH] git-gui: fix usage of themed widgets variable","fromName":"Pat Thoyts","fromEmail":"patthoyts@googlemail.com","sentAt":"2010-02-20T18:47:12Z","receivedAt":"2010-02-20T18:47:12Z","isPatch":true,"sender":{"key":"patthoyts@googlemail.com","avatar":"https://gravatar.com/avatar/2300f94d9f59174a551dbc71278ac2cb2489f56afda920a57e189ad9de0a3f92?d=mp&s=160"},"body":"On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:\n> There was one forgotten global so NS was not visible to the method\n> which resulted in an error.\n>\n> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>\n> ---\n>  git-gui/lib/status_bar.tcl |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl\n> index 5fe3aad..95cb449 100644\n> --- a/git-gui/lib/status_bar.tcl\n> +++ b/git-gui/lib/status_bar.tcl\n> @@ -39,6 +39,7 @@ method _oneline_pack {} {\n>  }\n>\n>  constructor two_line {path} {\n> +       global NS\n>        set w $path\n>        set w_l $w.l\n>        set w_c $w.c\n> --\n> 1.7.0.m5.rc2.13.g7abfa.dirty\n\nThe commit message should mention what triggered the error I think -\nbut this patch is clearly correct.\nYou can have a\n\nSigned-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n\nif you like :)\n\nPat Thoyts.\n"},{"id":"135169","messageId":"20100220185757.GH15561@book.hvoigt.net","threadId":"22741","inReplyTo":"a5b261831002201047r153a067btb7d2a9cf96617df4@mail.gmail.com","subject":"[PATCH v2] git-gui: fix usage of themed widgets variable","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2010-02-20T18:57:57Z","receivedAt":"2010-02-20T18:57:57Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"There was one forgotten global so NS was not visible to the method\nwhich resulted in an error.\n\nThe error was triggered by using git gui to clone a local repository.\n\nSigned-off-by: Heiko Voigt <hvoigt@hvoigt.net>\nSigned-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n---\nOn Sat, Feb 20, 2010 at 06:47:12PM +0000, Pat Thoyts wrote:\n> On 20 February 2010 18:01, Heiko Voigt <hvoigt@hvoigt.net> wrote:\n> > There was one forgotten global so NS was not visible to the method\n> > which resulted in an error.\n> >\n> > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>\n[...]\n> \n> The commit message should mention what triggered the error I think -\n> but this patch is clearly correct.\n> You can have a\n> \n> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>\n> \n> if you like :)\n\nThanks, taken.\n\n git-gui/lib/status_bar.tcl |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl\nindex 5fe3aad..95cb449 100644\n--- a/git-gui/lib/status_bar.tcl\n+++ b/git-gui/lib/status_bar.tcl\n@@ -39,6 +39,7 @@ method _oneline_pack {} {\n }\n \n constructor two_line {path} {\n+\tglobal NS\n \tset w $path\n \tset w_l $w.l\n \tset w_c $w.c\n-- \n1.7.0.m5.rc2.13.g7abfa.dirty\n"}]}