threads / discuss / 16664

builtin-add.c patch

Subject: builtin-add.c patch

## tl;dr

8 messages between Dec 10, 2008 and Dec 10, 2008.

replies: 7people: 4as markdown or json

daly@axiom-developer.org· Dec 10, 2008, 12:38 UTC · lore
A trivial patch to fix a typo -- Tim Daly
diff --git a/builtin-add.c b/builtin-add.c
index ea4e771..5f2e68b 100644
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)
 	int num_unmatched = 0, i;
 
 	/*
-	 * Since we are walking the index as if we are warlking the directory,
+	 * Since we are walking the index as if we are walking the directory,
 	 * we have to mark the matched pathspec as seen; otherwise we will
 	 * mistakenly think that the user gave a pathspec that did not match
 	 * anything.
Alexander Potashev· Dec 10, 2008, 14:26 UTC · re: daly@axiom-developer.org · lore

Re: builtin-add.c patch

Hello, Tim!
On 06:38 Wed 10 Dec     , daly@axiom-developer.org wrote:
Show 13 quoted lines
> A trivial patch to fix a typo -- Tim Daly
> 
> 
> diff --git a/builtin-add.c b/builtin-add.c
> index ea4e771..5f2e68b 100644
> --- a/builtin-add.c
> +++ b/builtin-add.c
> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)
>  	int num_unmatched = 0, i;
>  
>  	/*
> -	 * Since we are walking the index as if we are warlking the directory,
> +	 * Since we are walking the index as if we are walking the directory,

We probably should use subjunctive here: "Since we are walking the index as if we _were_ walking the directory,".

Are there any native English speakers? :)
Show 7 quoted lines
>  	 * we have to mark the matched pathspec as seen; otherwise we will
>  	 * mistakenly think that the user gave a pathspec that did not match
>  	 * anything.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

It's also better to change the commit message, one should be able to realize from it that the change is a typo fix in comments.

Boyd Stephen Smith Jr.· Dec 10, 2008, 16:01 UTC · re: Alexander Potashev · lore

Re: builtin-add.c patch

On Wednesday 2008 December 10 08:26:32 Alexander Potashev wrote:
Show 15 quoted lines
>> diff --git a/builtin-add.c b/builtin-add.c
>> index ea4e771..5f2e68b 100644
>> --- a/builtin-add.c
>> +++ b/builtin-add.c
>> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec,
>> char *seen, int specs) int num_unmatched = 0, i;
>>
>>  	/*
>> -	 * Since we are walking the index as if we are warlking the directory,
>> +	 * Since we are walking the index as if we are walking the directory,
>
>We probably should use subjunctive here:
>"Since we are walking the index as if we _were_ walking the directory,".
>
>Are there any native English speakers? :)
Southern bah the grace o' gawd. :)

Yes, the subjunctive is the appropriate tense for use in hypotheticals ("as if").

-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss03@volumehost.net                      ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.org/                      \_/    
Alexander Potashev· Dec 10, 2008, 22:27 UTC · re: root · lore

[PATCH (resend)] Fix typo in comment in builtin-add.c

Reported-by: Tim Daly <daly@axiom-developer.org>
Cc: Boyd Stephen Smith Jr. <bss03@volumehost.net>
Cc: Junio C Hamano <gitster@pobox.com>
Cc: <git@vger.kernel.org>
Signed-off-by: Alexander Potashev <aspotashev@gmail.com>
---
 builtin-add.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-add.c b/builtin-add.c
index ea4e771..719de8b 100644
--- a/builtin-add.c
+++ b/builtin-add.c
@@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)
 	int num_unmatched = 0, i;
 
 	/*
-	 * Since we are walking the index as if we are warlking the directory,
+	 * Since we are walking the index as if we were walking the directory,
 	 * we have to mark the matched pathspec as seen; otherwise we will
 	 * mistakenly think that the user gave a pathspec that did not match
 	 * anything.

-- 
1.6.0.4
Junio C Hamano· Dec 10, 2008, 23:38 UTC · re: Alexander Potashev · lore

Re: [PATCH (resend)] Fix typo in comment in builtin-add.c

Alexander Potashev <aspotashev@gmail.com> writes:
Show 5 quoted lines
> Reported-by: Tim Daly <daly@axiom-developer.org>
> Cc: Boyd Stephen Smith Jr. <bss03@volumehost.net>
> Cc: Junio C Hamano <gitster@pobox.com>
> Cc: <git@vger.kernel.org>
> Signed-off-by: Alexander Potashev <aspotashev@gmail.com>
Eek.  Why so many Cc: here for such a trivial patch?
Will apply, thanks.
root· Dec 10, 2008, 19:14 UTC · re: Alexander Potashev · lore

Re: builtin-add.c patch

Alexander,

I saw a suggestion that git could be used as a filesystem rather than as a code repository. I'm looking to convert it for this purpose to sit underneath Axiom, a computer algebra system written in common lisp. Basically the idea is that a "close" operation does a 'git add foo ; git commit'. 

Are you aware of anyone who has used git as a filesystem?
Tim Daly
Alexander Potashev· Dec 10, 2008, 20:10 UTC · re: root · lore

Re: builtin-add.c patch

Hello, Tim!
On 14:14 Wed 10 Dec     , root wrote:
Show 12 quoted lines
> Alexander,
> 
> I saw a suggestion that git could be used as a filesystem rather
> than as a code repository. I'm looking to convert it for this
> purpose to sit underneath Axiom, a computer algebra system written
> in common lisp. Basically the idea is that a "close" operation does
> a 'git add foo ; git commit'. 
> 
> Are you aware of anyone who has used git as a filesystem?
> 
> Tim Daly
>

It's a quite off-topic question. But Git is not optimized to track individual files with separate history ( see http://www.youtube.com/watch?v=8dhZ9BXQgc4 ). Also, Git uses only 644 and 755 permissions (755 stands for executables, often scripts - shell scripts, perl, ...), but usual filesystems provide full range of premissions/ownership.

                                 Alexander

← back to recent threads