Re: builtin-add.c patch

From: Alexander Potashev <aspotashev@gmail.com>
Date: Dec 10, 2008, 14:26 UTC
Message-ID: <20081210142632.GA4137@myhost>
In-Reply-To: <200812101238.mBACcWQk023480@axiom-developer.org>

Hello, Tim!

On 06:38 Wed 10 Dec     , daly@axiom-developer.org wrote:

Show 13 quoted lines

> A trivial patch to fix a typo -- Tim Daly
> 
> 
> diff --git a/builtin-add.c b/builtin-add.c
> index ea4e771..5f2e68b 100644
> --- a/builtin-add.c
> +++ b/builtin-add.c
> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)
>  	int num_unmatched = 0, i;
>  
>  	/*
> -	 * Since we are walking the index as if we are warlking the directory,
> +	 * Since we are walking the index as if we are walking the directory,

We probably should use subjunctive here: "Since we are walking the index as if we _were_ walking the directory,".

Are there any native English speakers? :)

Show 7 quoted lines

>  	 * we have to mark the matched pathspec as seen; otherwise we will
>  	 * mistakenly think that the user gave a pathspec that did not match
>  	 * anything.
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

It's also better to change the commit message, one should be able to realize from it that the change is a typo fix in comments.