Re: builtin-add.c patch

From: Boyd Stephen Smith Jr. <bss03@volumehost.net>
Date: Dec 10, 2008, 16:01 UTC
Message-ID: <200812101001.53738.bss03@volumehost.net>
In-Reply-To: <20081210142632.GA4137@myhost>

On Wednesday 2008 December 10 08:26:32 Alexander Potashev wrote:

Show 15 quoted lines

>> diff --git a/builtin-add.c b/builtin-add.c
>> index ea4e771..5f2e68b 100644
>> --- a/builtin-add.c
>> +++ b/builtin-add.c
>> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec,
>> char *seen, int specs) int num_unmatched = 0, i;
>>
>>  	/*
>> -	 * Since we are walking the index as if we are warlking the directory,
>> +	 * Since we are walking the index as if we are walking the directory,
>
>We probably should use subjunctive here:
>"Since we are walking the index as if we _were_ walking the directory,".
>
>Are there any native English speakers? :)

Southern bah the grace o' gawd. :)

Yes, the subjunctive is the appropriate tense for use in hypotheticals ("as if").

-- 
Boyd Stephen Smith Jr.                     ,= ,-_-. =. 
bss03@volumehost.net                      ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' 
http://iguanasuicide.org/                      \_/