{"thread":{"id":"16664","subject":"builtin-add.c patch","startedAt":"2008-12-10T12:38:32Z","lastAt":"2008-12-10T23:38:00Z","messageCount":8,"participants":["daly@axiom-developer.org","Alexander Potashev","Boyd Stephen Smith Jr.","root","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"97485","messageId":"200812101238.mBACcWQk023480@axiom-developer.org","threadId":"16664","inReplyTo":null,"subject":"builtin-add.c patch","fromName":"","fromEmail":"daly@axiom-developer.org","sentAt":"2008-12-10T12:38:32Z","receivedAt":"2008-12-10T12:38:32Z","isPatch":false,"sender":{"key":"daly@axiom-developer.org","avatar":null},"body":"A trivial patch to fix a typo -- Tim Daly\n\n\ndiff --git a/builtin-add.c b/builtin-add.c\nindex ea4e771..5f2e68b 100644\n--- a/builtin-add.c\n+++ b/builtin-add.c\n@@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)\n \tint num_unmatched = 0, i;\n \n \t/*\n-\t * Since we are walking the index as if we are warlking the directory,\n+\t * Since we are walking the index as if we are walking the directory,\n \t * we have to mark the matched pathspec as seen; otherwise we will\n \t * mistakenly think that the user gave a pathspec that did not match\n \t * anything.\n"},{"id":"97489","messageId":"20081210142632.GA4137@myhost","threadId":"16664","inReplyTo":"200812101238.mBACcWQk023480@axiom-developer.org","subject":"Re: builtin-add.c patch","fromName":"Alexander Potashev","fromEmail":"aspotashev@gmail.com","sentAt":"2008-12-10T14:26:32Z","receivedAt":"2008-12-10T14:26:32Z","isPatch":false,"sender":{"key":"aspotashev@gmail.com","avatar":null},"body":"Hello, Tim!\n\nOn 06:38 Wed 10 Dec , daly@axiom-developer.org wrote:\n> A trivial patch to fix a typo -- Tim Daly\n> \n> \n> diff --git a/builtin-add.c b/builtin-add.c\n> index ea4e771..5f2e68b 100644\n> --- a/builtin-add.c\n> +++ b/builtin-add.c\n> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)\n> \tint num_unmatched = 0, i;\n> \n> \t/*\n> -\t * Since we are walking the index as if we are warlking the directory,\n> +\t * Since we are walking the index as if we are walking the directory,\nWe probably should use subjunctive here:\n\"Since we are walking the index as if we _were_ walking the directory,\".\n\nAre there any native English speakers? :)\n> \t * we have to mark the matched pathspec as seen; otherwise we will\n> \t * mistakenly think that the user gave a pathspec that did not match\n> \t * anything.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\nIt's also better to change the commit message, one should be able to\nrealize from it that the change is a typo fix in comments.\n"},{"id":"97494","messageId":"200812101001.53738.bss03@volumehost.net","threadId":"16664","inReplyTo":"20081210142632.GA4137@myhost","subject":"Re: builtin-add.c patch","fromName":"Boyd Stephen Smith Jr.","fromEmail":"bss03@volumehost.net","sentAt":"2008-12-10T16:01:48Z","receivedAt":"2008-12-10T16:01:48Z","isPatch":false,"sender":{"key":"bss03@volumehost.net","avatar":"https://gravatar.com/avatar/74fa10b37dfd44462a6a30c4d4e3bda26ab7991ddb0d8ab24b022714a8ecb918?d=mp&s=160"},"body":"On Wednesday 2008 December 10 08:26:32 Alexander Potashev wrote:\n>> diff --git a/builtin-add.c b/builtin-add.c\n>> index ea4e771..5f2e68b 100644\n>> --- a/builtin-add.c\n>> +++ b/builtin-add.c\n>> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec,\n>> char *seen, int specs) int num_unmatched = 0, i;\n>>\n>> \t/*\n>> -\t * Since we are walking the index as if we are warlking the directory,\n>> +\t * Since we are walking the index as if we are walking the directory,\n>\n>We probably should use subjunctive here:\n>\"Since we are walking the index as if we _were_ walking the directory,\".\n>\n>Are there any native English speakers? :)\n\nSouthern bah the grace o' gawd. :)\n\nYes, the subjunctive is the appropriate tense for use in hypotheticals (\"as \nif\").\n-- \nBoyd Stephen Smith Jr.                     ,= ,-_-. =. \nbss03@volumehost.net                      ((_/)o o(\\_))\nICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' \nhttp://iguanasuicide.org/                      \\_/     \n"},{"id":"97501","messageId":"200812101910.mBAJAsF04710@localhost.localdomain","threadId":"16664","inReplyTo":"20081210142632.GA4137@myhost","subject":"Re: builtin-add.c patch","fromName":"root","fromEmail":"daly@axiom-developer.org","sentAt":"2008-12-10T19:10:54Z","receivedAt":"2008-12-10T19:10:54Z","isPatch":false,"sender":{"key":"daly@axiom-developer.org","avatar":null},"body":"Alexander,\n\nFeel free to change the patch.\nIts hardly worth the bits of email used\nbut it does need to be fixed.\n\nTim\n"},{"id":"97502","messageId":"200812101914.mBAJEAS04718@localhost.localdomain","threadId":"16664","inReplyTo":"20081210142632.GA4137@myhost","subject":"Re: builtin-add.c patch","fromName":"root","fromEmail":"daly@axiom-developer.org","sentAt":"2008-12-10T19:14:10Z","receivedAt":"2008-12-10T19:14:10Z","isPatch":false,"sender":{"key":"daly@axiom-developer.org","avatar":null},"body":"Alexander,\n\nI saw a suggestion that git could be used as a filesystem rather\nthan as a code repository. I'm looking to convert it for this\npurpose to sit underneath Axiom, a computer algebra system written\nin common lisp. Basically the idea is that a \"close\" operation does\na 'git add foo ; git commit'. \n\nAre you aware of anyone who has used git as a filesystem?\n\nTim Daly\n"},{"id":"97510","messageId":"20081210201011.GA11244@myhost","threadId":"16664","inReplyTo":"200812101914.mBAJEAS04718@localhost.localdomain","subject":"Re: builtin-add.c patch","fromName":"Alexander Potashev","fromEmail":"aspotashev@gmail.com","sentAt":"2008-12-10T20:10:11Z","receivedAt":"2008-12-10T20:10:11Z","isPatch":false,"sender":{"key":"aspotashev@gmail.com","avatar":null},"body":"Hello, Tim!\n\nOn 14:14 Wed 10 Dec , root wrote:\n> Alexander,\n> \n> I saw a suggestion that git could be used as a filesystem rather\n> than as a code repository. I'm looking to convert it for this\n> purpose to sit underneath Axiom, a computer algebra system written\n> in common lisp. Basically the idea is that a \"close\" operation does\n> a 'git add foo ; git commit'. \n> \n> Are you aware of anyone who has used git as a filesystem?\n> \n> Tim Daly\n> \n\nIt's a quite off-topic question. But Git is not optimized to track\nindividual files with separate history\n( see http://www.youtube.com/watch?v=8dhZ9BXQgc4 ).\nAlso, Git uses only 644 and 755 permissions (755 stands for\nexecutables, often scripts - shell scripts, perl, ...), but\nusual filesystems provide full range of premissions/ownership.\n\n Alexander\n"},{"id":"97532","messageId":"1228948064-4006-1-git-send-email-aspotashev@gmail.com","threadId":"16664","inReplyTo":"200812101910.mBAJAsF04710@localhost.localdomain","subject":"[PATCH (resend)] Fix typo in comment in builtin-add.c","fromName":"Alexander Potashev","fromEmail":"aspotashev@gmail.com","sentAt":"2008-12-10T22:27:44Z","receivedAt":"2008-12-10T22:27:44Z","isPatch":true,"sender":{"key":"aspotashev@gmail.com","avatar":null},"body":"Reported-by: Tim Daly \nCc: Boyd Stephen Smith Jr. \nCc: Junio C Hamano \nCc: \nSigned-off-by: Alexander Potashev \n---\n builtin-add.c | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/builtin-add.c b/builtin-add.c\nindex ea4e771..719de8b 100644\n--- a/builtin-add.c\n+++ b/builtin-add.c\n@@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs)\n \tint num_unmatched = 0, i;\n \n \t/*\n-\t * Since we are walking the index as if we are warlking the directory,\n+\t * Since we are walking the index as if we were walking the directory,\n \t * we have to mark the matched pathspec as seen; otherwise we will\n \t * mistakenly think that the user gave a pathspec that did not match\n \t * anything.\n-- \n1.6.0.4\n"},{"id":"97541","messageId":"7vk5a7y52f.fsf@gitster.siamese.dyndns.org","threadId":"16664","inReplyTo":"1228948064-4006-1-git-send-email-aspotashev@gmail.com","subject":"Re: [PATCH (resend)] Fix typo in comment in builtin-add.c","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-12-10T23:38:00Z","receivedAt":"2008-12-10T23:38:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Alexander Potashev writes:\n\n> Reported-by: Tim Daly \n> Cc: Boyd Stephen Smith Jr. \n> Cc: Junio C Hamano \n> Cc: \n> Signed-off-by: Alexander Potashev \n\nEek. Why so many Cc: here for such a trivial patch?\n\nWill apply, thanks.\n"}]}