# builtin-add.c patch 8 messages from 2008-12-10 to 2008-12-10. Participants: daly@axiom-developer.org, Alexander Potashev, Boyd Stephen Smith Jr., root, Junio C Hamano. Thread: https://gitlist.dev/t/16664 ## daly@axiom-developer.org, 2008-12-10 12:38 Subject: builtin-add.c patch Message-ID: <200812101238.mBACcWQk023480@axiom-developer.org> URL: https://gitlist.dev/e/200812101238.mBACcWQk023480%40axiom-developer.org ``` A trivial patch to fix a typo -- Tim Daly diff --git a/builtin-add.c b/builtin-add.c index ea4e771..5f2e68b 100644 --- a/builtin-add.c +++ b/builtin-add.c @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs) int num_unmatched = 0, i; /* - * Since we are walking the index as if we are warlking the directory, + * Since we are walking the index as if we are walking the directory, * we have to mark the matched pathspec as seen; otherwise we will * mistakenly think that the user gave a pathspec that did not match * anything. ``` ## Alexander Potashev, 2008-12-10 14:26 Subject: Re: builtin-add.c patch Message-ID: <20081210142632.GA4137@myhost> URL: https://gitlist.dev/e/20081210142632.GA4137%40myhost In-Reply-To: <200812101238.mBACcWQk023480@axiom-developer.org> ``` Hello, Tim! On 06:38 Wed 10 Dec , daly@axiom-developer.org wrote: > A trivial patch to fix a typo -- Tim Daly > > > diff --git a/builtin-add.c b/builtin-add.c > index ea4e771..5f2e68b 100644 > --- a/builtin-add.c > +++ b/builtin-add.c > @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs) > int num_unmatched = 0, i; > > /* > - * Since we are walking the index as if we are warlking the directory, > + * Since we are walking the index as if we are walking the directory, We probably should use subjunctive here: "Since we are walking the index as if we _were_ walking the directory,". Are there any native English speakers? :) > * we have to mark the matched pathspec as seen; otherwise we will > * mistakenly think that the user gave a pathspec that did not match > * anything. > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html It's also better to change the commit message, one should be able to realize from it that the change is a typo fix in comments. ``` ## Boyd Stephen Smith Jr., 2008-12-10 16:01 Subject: Re: builtin-add.c patch Message-ID: <200812101001.53738.bss03@volumehost.net> URL: https://gitlist.dev/e/200812101001.53738.bss03%40volumehost.net In-Reply-To: <20081210142632.GA4137@myhost> ``` On Wednesday 2008 December 10 08:26:32 Alexander Potashev wrote: >> diff --git a/builtin-add.c b/builtin-add.c >> index ea4e771..5f2e68b 100644 >> --- a/builtin-add.c >> +++ b/builtin-add.c >> @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, >> char *seen, int specs) int num_unmatched = 0, i; >> >> /* >> - * Since we are walking the index as if we are warlking the directory, >> + * Since we are walking the index as if we are walking the directory, > >We probably should use subjunctive here: >"Since we are walking the index as if we _were_ walking the directory,". > >Are there any native English speakers? :) Southern bah the grace o' gawd. :) Yes, the subjunctive is the appropriate tense for use in hypotheticals ("as if"). -- Boyd Stephen Smith Jr.                     ,= ,-_-. =. bss03@volumehost.net                      ((_/)o o(\_)) ICQ: 514984 YM/AIM: DaTwinkDaddy           `-'(. .)`-' http://iguanasuicide.org/                      \_/     ``` ## root, 2008-12-10 19:10 Subject: Re: builtin-add.c patch Message-ID: <200812101910.mBAJAsF04710@localhost.localdomain> URL: https://gitlist.dev/e/200812101910.mBAJAsF04710%40localhost.localdomain In-Reply-To: <20081210142632.GA4137@myhost> ``` Alexander, Feel free to change the patch. Its hardly worth the bits of email used but it does need to be fixed. Tim ``` ## root, 2008-12-10 19:14 Subject: Re: builtin-add.c patch Message-ID: <200812101914.mBAJEAS04718@localhost.localdomain> URL: https://gitlist.dev/e/200812101914.mBAJEAS04718%40localhost.localdomain In-Reply-To: <20081210142632.GA4137@myhost> ``` Alexander, I saw a suggestion that git could be used as a filesystem rather than as a code repository. I'm looking to convert it for this purpose to sit underneath Axiom, a computer algebra system written in common lisp. Basically the idea is that a "close" operation does a 'git add foo ; git commit'. Are you aware of anyone who has used git as a filesystem? Tim Daly ``` ## Alexander Potashev, 2008-12-10 20:10 Subject: Re: builtin-add.c patch Message-ID: <20081210201011.GA11244@myhost> URL: https://gitlist.dev/e/20081210201011.GA11244%40myhost In-Reply-To: <200812101914.mBAJEAS04718@localhost.localdomain> ``` Hello, Tim! On 14:14 Wed 10 Dec , root wrote: > Alexander, > > I saw a suggestion that git could be used as a filesystem rather > than as a code repository. I'm looking to convert it for this > purpose to sit underneath Axiom, a computer algebra system written > in common lisp. Basically the idea is that a "close" operation does > a 'git add foo ; git commit'. > > Are you aware of anyone who has used git as a filesystem? > > Tim Daly > It's a quite off-topic question. But Git is not optimized to track individual files with separate history ( see http://www.youtube.com/watch?v=8dhZ9BXQgc4 ). Also, Git uses only 644 and 755 permissions (755 stands for executables, often scripts - shell scripts, perl, ...), but usual filesystems provide full range of premissions/ownership. Alexander ``` ## Alexander Potashev, 2008-12-10 22:27 Subject: [PATCH (resend)] Fix typo in comment in builtin-add.c Message-ID: <1228948064-4006-1-git-send-email-aspotashev@gmail.com> URL: https://gitlist.dev/e/1228948064-4006-1-git-send-email-aspotashev%40gmail.com In-Reply-To: <200812101910.mBAJAsF04710@localhost.localdomain> ``` Reported-by: Tim Daly Cc: Boyd Stephen Smith Jr. Cc: Junio C Hamano Cc: Signed-off-by: Alexander Potashev --- builtin-add.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/builtin-add.c b/builtin-add.c index ea4e771..719de8b 100644 --- a/builtin-add.c +++ b/builtin-add.c @@ -23,7 +23,7 @@ static void fill_pathspec_matches(const char **pathspec, char *seen, int specs) int num_unmatched = 0, i; /* - * Since we are walking the index as if we are warlking the directory, + * Since we are walking the index as if we were walking the directory, * we have to mark the matched pathspec as seen; otherwise we will * mistakenly think that the user gave a pathspec that did not match * anything. -- 1.6.0.4 ``` ## Junio C Hamano, 2008-12-10 23:38 Subject: Re: [PATCH (resend)] Fix typo in comment in builtin-add.c Message-ID: <7vk5a7y52f.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vk5a7y52f.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1228948064-4006-1-git-send-email-aspotashev@gmail.com> ``` Alexander Potashev writes: > Reported-by: Tim Daly > Cc: Boyd Stephen Smith Jr. > Cc: Junio C Hamano > Cc: > Signed-off-by: Alexander Potashev Eek. Why so many Cc: here for such a trivial patch? Will apply, thanks. ```