threads / patch / 12916

patchgit-svn: remove redundant slashes from show-ignore

Subject: [PATCH] git-svn: remove redundant slashes from show-ignore

## tl;dr

4 messages between Mar 29, 2008 and Mar 31, 2008. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Eric Wong· Mar 29, 2008, 23:37 UTC · lore

Jonathan Scott Duff wrote:

Show 8 quoted lines

> Recently I tried "git svn showignore" on my parrot repository and it
> failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> $path has an extra / on the beginning (i.e., when it recurses, it
> tries to get the props for "//apps" instead of "/apps").   I *think*
> this is because $path is used in the recursive call rather than $p
> (which seems to contain a properly transformed $path).  Anyway, I've
> attached a patch that works for me and I think is generally the right
> thing.

Patch-submitted-by: Jonathan Scott Duff
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---

 Thanks Jonathan

 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to git-svn.perl +1 −1

diff --git a/git-svn.perl b/git-svn.perl
index 073471f..bc0c22c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1903,7 +1903,7 @@ sub prop_walk {
 
 	foreach (sort keys %$dirent) {
 		next if $dirent->{$_}->{kind} != $SVN::Node::dir;
-		$self->prop_walk($path . '/' . $_, $rev, $sub);
+		$self->prop_walk($p . $_, $rev, $sub);
 	}
 }

-- 
Eric Wong

Harvey Harrison· Mar 29, 2008, 23:47 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: remove redundant slashes from show-ignore

On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:

Show 11 quoted lines

> Jonathan Scott Duff wrote:
> > Recently I tried "git svn showignore" on my parrot repository and it
> > failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> > $path has an extra / on the beginning (i.e., when it recurses, it
> > tries to get the props for "//apps" instead of "/apps").   I *think*
> > this is because $path is used in the recursive call rather than $p
> > (which seems to contain a properly transformed $path).  Anyway, I've
> > attached a patch that works for me and I think is generally the right
> > thing.
> 
> Patch-submitted-by: Jonathan Scott Duff

Shouldn't that be Signed-off-by?

Cheers,

Harvey

Eric Wong· Mar 30, 2008, 01:36 UTC · re: Harvey Harrison · lore

Re: [PATCH] git-svn: remove redundant slashes from show-ignore

Harvey Harrison <harvey.harrison@gmail.com> wrote:

Show 14 quoted lines

> On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:
> > Jonathan Scott Duff wrote:
> > > Recently I tried "git svn showignore" on my parrot repository and it
> > > failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> > > $path has an extra / on the beginning (i.e., when it recurses, it
> > > tries to get the props for "//apps" instead of "/apps").   I *think*
> > > this is because $path is used in the recursive call rather than $p
> > > (which seems to contain a properly transformed $path).  Anyway, I've
> > > attached a patch that works for me and I think is generally the right
> > > thing.
> > 
> > Patch-submitted-by: Jonathan Scott Duff
> 
> Shouldn't that be Signed-off-by?

I'm not sure what the proper protocol for this should be, as Jonathan emailed the patch to me privately without a sign-off...

[1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid
  putting his address on the list.

-- 
Eric Wong

Eric Wong· Mar 31, 2008, 06:26 UTC · re: Eric Wong · lore

Re: [PATCH] git-svn: remove redundant slashes from show-ignore

Eric Wong <normalperson@yhbt.net> wrote:

Show 21 quoted lines

> Harvey Harrison <harvey.harrison@gmail.com> wrote:
> > On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:
> > > Jonathan Scott Duff wrote:
> > > > Recently I tried "git svn showignore" on my parrot repository and it
> > > > failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> > > > $path has an extra / on the beginning (i.e., when it recurses, it
> > > > tries to get the props for "//apps" instead of "/apps").   I *think*
> > > > this is because $path is used in the recursive call rather than $p
> > > > (which seems to contain a properly transformed $path).  Anyway, I've
> > > > attached a patch that works for me and I think is generally the right
> > > > thing.
> > > 
> > > Patch-submitted-by: Jonathan Scott Duff
> > 
> > Shouldn't that be Signed-off-by?
> 
> I'm not sure what the proper protocol for this should be,
> as Jonathan emailed the patch to me privately without a sign-off...
> 
> [1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid
>   putting his address on the list.

Signed-off-by: Jonathan Scott Duff

Jonathan Scott Duff wrote:

> Er ... yeah.  I've very new to git (long time svn user though) so I don't
> know what the cultural norms are here.  So if I need to "sign off" on the
> patch, consider it signed off :-)

-- 
Eric Wong