{"thread":{"id":"12916","subject":"[PATCH] git-svn: remove redundant slashes from show-ignore","startedAt":"2008-03-29T23:37:17Z","lastAt":"2008-03-31T06:26:37Z","messageCount":4,"participants":["Eric Wong","Harvey Harrison"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73343","messageId":"20080329233717.GA16157@soma","threadId":"12916","inReplyTo":"b762bfda0803291340ta70ee88k8d5d7c7e384e41e0@mail.gmail.com","subject":"[PATCH] git-svn: remove redundant slashes from show-ignore","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-03-29T23:37:17Z","receivedAt":"2008-03-29T23:37:17Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jonathan Scott Duff wrote:\n> Recently I tried \"git svn showignore\" on my parrot repository and it\n> failed. I tracked it down to the prop_walk() sub. When it recurses,\n> $path has an extra / on the beginning (i.e., when it recurses, it\n> tries to get the props for \"//apps\" instead of \"/apps\"). I *think*\n> this is because $path is used in the recursive call rather than $p\n> (which seems to contain a properly transformed $path). Anyway, I've\n> attached a patch that works for me and I think is generally the right\n> thing.\n\nPatch-submitted-by: Jonathan Scott Duff\nSigned-off-by: Eric Wong \n---\n\n Thanks Jonathan\n\n git-svn.perl | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 073471f..bc0c22c 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -1903,7 +1903,7 @@ sub prop_walk {\n \n \tforeach (sort keys %$dirent) {\n \t\tnext if $dirent->{$_}->{kind} != $SVN::Node::dir;\n-\t\t$self->prop_walk($path . '/' . $_, $rev, $sub);\n+\t\t$self->prop_walk($p . $_, $rev, $sub);\n \t}\n }\n \n-- \nEric Wong\n"},{"id":"73344","messageId":"1206834466.6543.30.camel@brick","threadId":"12916","inReplyTo":"20080329233717.GA16157@soma","subject":"Re: [PATCH] git-svn: remove redundant slashes from show-ignore","fromName":"Harvey Harrison","fromEmail":"harvey.harrison@gmail.com","sentAt":"2008-03-29T23:47:46Z","receivedAt":"2008-03-29T23:47:46Z","isPatch":true,"sender":{"key":"harvey.harrison@gmail.com","avatar":null},"body":"On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:\n> Jonathan Scott Duff wrote:\n> > Recently I tried \"git svn showignore\" on my parrot repository and it\n> > failed. I tracked it down to the prop_walk() sub. When it recurses,\n> > $path has an extra / on the beginning (i.e., when it recurses, it\n> > tries to get the props for \"//apps\" instead of \"/apps\"). I *think*\n> > this is because $path is used in the recursive call rather than $p\n> > (which seems to contain a properly transformed $path). Anyway, I've\n> > attached a patch that works for me and I think is generally the right\n> > thing.\n> \n> Patch-submitted-by: Jonathan Scott Duff\n\nShouldn't that be Signed-off-by?\n\nCheers,\n\nHarvey\n"},{"id":"73346","messageId":"20080330013600.GB16157@soma","threadId":"12916","inReplyTo":"1206834466.6543.30.camel@brick","subject":"Re: [PATCH] git-svn: remove redundant slashes from show-ignore","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-03-30T01:36:00Z","receivedAt":"2008-03-30T01:36:00Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Harvey Harrison wrote:\n> On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:\n> > Jonathan Scott Duff wrote:\n> > > Recently I tried \"git svn showignore\" on my parrot repository and it\n> > > failed. I tracked it down to the prop_walk() sub. When it recurses,\n> > > $path has an extra / on the beginning (i.e., when it recurses, it\n> > > tries to get the props for \"//apps\" instead of \"/apps\"). I *think*\n> > > this is because $path is used in the recursive call rather than $p\n> > > (which seems to contain a properly transformed $path). Anyway, I've\n> > > attached a patch that works for me and I think is generally the right\n> > > thing.\n> > \n> > Patch-submitted-by: Jonathan Scott Duff\n> \n> Shouldn't that be Signed-off-by?\n\nI'm not sure what the proper protocol for this should be,\nas Jonathan emailed the patch to me privately without a sign-off...\n\n[1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid\n putting his address on the list.\n\n-- \nEric Wong\n"},{"id":"73415","messageId":"20080331062637.GA3082@hand.yhbt.net","threadId":"12916","inReplyTo":"20080330013600.GB16157@soma","subject":"Re: [PATCH] git-svn: remove redundant slashes from show-ignore","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2008-03-31T06:26:37Z","receivedAt":"2008-03-31T06:26:37Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Eric Wong wrote:\n> Harvey Harrison wrote:\n> > On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:\n> > > Jonathan Scott Duff wrote:\n> > > > Recently I tried \"git svn showignore\" on my parrot repository and it\n> > > > failed. I tracked it down to the prop_walk() sub. When it recurses,\n> > > > $path has an extra / on the beginning (i.e., when it recurses, it\n> > > > tries to get the props for \"//apps\" instead of \"/apps\"). I *think*\n> > > > this is because $path is used in the recursive call rather than $p\n> > > > (which seems to contain a properly transformed $path). Anyway, I've\n> > > > attached a patch that works for me and I think is generally the right\n> > > > thing.\n> > > \n> > > Patch-submitted-by: Jonathan Scott Duff\n> > \n> > Shouldn't that be Signed-off-by?\n> \n> I'm not sure what the proper protocol for this should be,\n> as Jonathan emailed the patch to me privately without a sign-off...\n> \n> [1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid\n> putting his address on the list.\n\nSigned-off-by: Jonathan Scott Duff\n\nJonathan Scott Duff wrote:\n> Er ... yeah. I've very new to git (long time svn user though) so I don't\n> know what the cultural norms are here. So if I need to \"sign off\" on the\n> patch, consider it signed off :-)\n\n-- \nEric Wong\n"}]}