Re: [PATCH] git-svn: remove redundant slashes from show-ignore

From: Eric Wong <normalperson@yhbt.net>
Date: Mar 30, 2008, 01:36 UTC
Message-ID: <20080330013600.GB16157@soma>
In-Reply-To: <1206834466.6543.30.camel@brick>

Harvey Harrison <harvey.harrison@gmail.com> wrote:

Show 14 quoted lines

> On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote:
> > Jonathan Scott Duff wrote:
> > > Recently I tried "git svn showignore" on my parrot repository and it
> > > failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> > > $path has an extra / on the beginning (i.e., when it recurses, it
> > > tries to get the props for "//apps" instead of "/apps").   I *think*
> > > this is because $path is used in the recursive call rather than $p
> > > (which seems to contain a properly transformed $path).  Anyway, I've
> > > attached a patch that works for me and I think is generally the right
> > > thing.
> > 
> > Patch-submitted-by: Jonathan Scott Duff
> 
> Shouldn't that be Signed-off-by?

I'm not sure what the proper protocol for this should be, as Jonathan emailed the patch to me privately without a sign-off...

[1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid
  putting his address on the list.

-- 
Eric Wong