# [PATCH] git-svn: remove redundant slashes from show-ignore 4 messages from 2008-03-29 to 2008-03-31. Participants: Eric Wong, Harvey Harrison. Thread: https://gitlist.dev/t/12916 ## Eric Wong, 2008-03-29 23:37 Subject: [PATCH] git-svn: remove redundant slashes from show-ignore Message-ID: <20080329233717.GA16157@soma> URL: https://gitlist.dev/e/20080329233717.GA16157%40soma In-Reply-To: ``` Jonathan Scott Duff wrote: > Recently I tried "git svn showignore" on my parrot repository and it > failed. I tracked it down to the prop_walk() sub. When it recurses, > $path has an extra / on the beginning (i.e., when it recurses, it > tries to get the props for "//apps" instead of "/apps"). I *think* > this is because $path is used in the recursive call rather than $p > (which seems to contain a properly transformed $path). Anyway, I've > attached a patch that works for me and I think is generally the right > thing. Patch-submitted-by: Jonathan Scott Duff Signed-off-by: Eric Wong --- Thanks Jonathan git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 073471f..bc0c22c 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1903,7 +1903,7 @@ sub prop_walk { foreach (sort keys %$dirent) { next if $dirent->{$_}->{kind} != $SVN::Node::dir; - $self->prop_walk($path . '/' . $_, $rev, $sub); + $self->prop_walk($p . $_, $rev, $sub); } } -- Eric Wong ``` ## Harvey Harrison, 2008-03-29 23:47 Subject: Re: [PATCH] git-svn: remove redundant slashes from show-ignore Message-ID: <1206834466.6543.30.camel@brick> URL: https://gitlist.dev/e/1206834466.6543.30.camel%40brick In-Reply-To: <20080329233717.GA16157@soma> ``` On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote: > Jonathan Scott Duff wrote: > > Recently I tried "git svn showignore" on my parrot repository and it > > failed. I tracked it down to the prop_walk() sub. When it recurses, > > $path has an extra / on the beginning (i.e., when it recurses, it > > tries to get the props for "//apps" instead of "/apps"). I *think* > > this is because $path is used in the recursive call rather than $p > > (which seems to contain a properly transformed $path). Anyway, I've > > attached a patch that works for me and I think is generally the right > > thing. > > Patch-submitted-by: Jonathan Scott Duff Shouldn't that be Signed-off-by? Cheers, Harvey ``` ## Eric Wong, 2008-03-30 01:36 Subject: Re: [PATCH] git-svn: remove redundant slashes from show-ignore Message-ID: <20080330013600.GB16157@soma> URL: https://gitlist.dev/e/20080330013600.GB16157%40soma In-Reply-To: <1206834466.6543.30.camel@brick> ``` Harvey Harrison wrote: > On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote: > > Jonathan Scott Duff wrote: > > > Recently I tried "git svn showignore" on my parrot repository and it > > > failed. I tracked it down to the prop_walk() sub. When it recurses, > > > $path has an extra / on the beginning (i.e., when it recurses, it > > > tries to get the props for "//apps" instead of "/apps"). I *think* > > > this is because $path is used in the recursive call rather than $p > > > (which seems to contain a properly transformed $path). Anyway, I've > > > attached a patch that works for me and I think is generally the right > > > thing. > > > > Patch-submitted-by: Jonathan Scott Duff > > Shouldn't that be Signed-off-by? I'm not sure what the proper protocol for this should be, as Jonathan emailed the patch to me privately without a sign-off... [1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid putting his address on the list. -- Eric Wong ``` ## Eric Wong, 2008-03-31 06:26 Subject: Re: [PATCH] git-svn: remove redundant slashes from show-ignore Message-ID: <20080331062637.GA3082@hand.yhbt.net> URL: https://gitlist.dev/e/20080331062637.GA3082%40hand.yhbt.net In-Reply-To: <20080330013600.GB16157@soma> ``` Eric Wong wrote: > Harvey Harrison wrote: > > On Sat, 2008-03-29 at 16:37 -0700, Eric Wong wrote: > > > Jonathan Scott Duff wrote: > > > > Recently I tried "git svn showignore" on my parrot repository and it > > > > failed. I tracked it down to the prop_walk() sub. When it recurses, > > > > $path has an extra / on the beginning (i.e., when it recurses, it > > > > tries to get the props for "//apps" instead of "/apps"). I *think* > > > > this is because $path is used in the recursive call rather than $p > > > > (which seems to contain a properly transformed $path). Anyway, I've > > > > attached a patch that works for me and I think is generally the right > > > > thing. > > > > > > Patch-submitted-by: Jonathan Scott Duff > > > > Shouldn't that be Signed-off-by? > > I'm not sure what the proper protocol for this should be, > as Jonathan emailed the patch to me privately without a sign-off... > > [1] - Out of respect for his privacy, I'm only Bcc-ing him to avoid > putting his address on the list. Signed-off-by: Jonathan Scott Duff Jonathan Scott Duff wrote: > Er ... yeah. I've very new to git (long time svn user though) so I don't > know what the cultural norms are here. So if I need to "sign off" on the > patch, consider it signed off :-) -- Eric Wong ```