git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: remove redundant slashes from show-ignore

From
EWEric Wong <normalperson@yhbt.net>
Date
Mar 29, 2008, 23:37 UTC
Message-ID
<20080329233717.GA16157@soma>
In-Reply-To
<b762bfda0803291340ta70ee88k8d5d7c7e384e41e0@mail.gmail.com>
Jonathan Scott Duff wrote:
Show 8 quoted lines
> Recently I tried "git svn showignore" on my parrot repository and it
> failed.  I tracked it down to the prop_walk() sub.  When it recurses,
> $path has an extra / on the beginning (i.e., when it recurses, it
> tries to get the props for "//apps" instead of "/apps").   I *think*
> this is because $path is used in the recursive call rather than $p
> (which seems to contain a properly transformed $path).  Anyway, I've
> attached a patch that works for me and I think is generally the right
> thing.
Patch-submitted-by: Jonathan Scott Duff
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
 Thanks Jonathan
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 073471f..bc0c22c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1903,7 +1903,7 @@ sub prop_walk {
 
 	foreach (sort keys %$dirent) {
 		next if $dirent->{$_}->{kind} != $SVN::Node::dir;
-		$self->prop_walk($path . '/' . $_, $rev, $sub);
+		$self->prop_walk($p . $_, $rev, $sub);
 	}
 }
 
-- 
Eric Wong
Next: Harvey Harrison
Message 1 of 4 in “git-svn: remove redundant slashes from show-ignore”
  1. git-svn: remove redundant slashes from show-ignoreEric Wong, Mar 29, 2008
  2. Harvey HarrisonMar 29, 2008
  3. Eric WongMar 30, 2008
  4. Eric WongMar 31, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.