threads / patch / 11129

patchRe: [PATCH] Set OLD_ICONV on Cygwin.

Subject: Re: [PATCH] Set OLD_ICONV on Cygwin.

## tl;dr

5 messages between Dec 4, 2007 and Dec 4, 2007. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Pascal Obry· Dec 4, 2007, 13:39 UTC · lore

Andreas Ericsson wrote:

> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.

Hum, I don't think this is a requirement. At least nothing is said about CCing Junio on the Git Web site.

Anyway, now Junio is CCed :)

Pascal.

Andreas Ericsson· Dec 4, 2007, 13:43 UTC · re: Pascal Obry · lore

Pascal Obry wrote:

Show 6 quoted lines

> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
> 
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
>

It's not a requirement, but he won't act on things he doesn't see, and CC'ing him directly is the recommended way of getting his attention. Most people do so for patches that aren't directly related to a sub-part of git primarily maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn, etc., etc.)

> Anyway, now Junio is CCed :)
>

Nice. If my suspicions are correct and he missed your patch the first time around, you should probably resend it though.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231

Junio C Hamano· Dec 4, 2007, 17:54 UTC · re: Andreas Ericsson · lore

Andreas Ericsson <ae@op5.se> writes:

> Nice. If my suspicions are correct and he missed your patch the first time
> around, you should probably resend it though.

I still have it in my mailbox.

I saw the patch but saw nobody else said about the patch being helpful to his installation, nor more importantly, "Good, this won't hurt for me who run a different vintage of Cygwin", and I was waiting for such confirmations.

Then nobody responded, so I forgot.

That was what happened the first time Pascal's patch was posted.

Junio C Hamano· Dec 4, 2007, 21:59 UTC · re: Junio C Hamano · lore

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Andreas Ericsson <ae@op5.se> writes:
>
>> Nice. If my suspicions are correct and he missed your patch the first time
>> around, you should probably resend it though.
>
> I still have it in my mailbox.
>
> I saw the patch but saw nobody else said about the patch being helpful
> to his installation, nor more importantly, "Good, this won't hurt for me
> who run a different vintage of Cygwin", and I was waiting for such
> confirmations.
>
> Then nobody responded, so I forgot.
>
> That was what happened the first time Pascal's patch was posted.

I think the patch is fine; I just checked with my copy of Cygwin that I haven't fired for some time (it was a pain waiting for it to update to the latest set of git sources).

I am at work and will be busy for the rest of the afternoon, so won't be applying it until this evening, though.

Pascal Obry· Dec 4, 2007, 22:12 UTC · re: Junio C Hamano · lore

Junio C Hamano a écrit :

> I am at work and will be busy for the rest of the afternoon, so won't be
> applying it until this evening, though.

Ok, thanks. No urgency with this patch anyway.

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595