Re: [PATCH] Set OLD_ICONV on Cygwin.

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 4, 2007, 21:59 UTC
Message-ID: <7vaboq3yuy.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7v63ze5osn.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Andreas Ericsson <ae@op5.se> writes:
>
>> Nice. If my suspicions are correct and he missed your patch the first time
>> around, you should probably resend it though.
>
> I still have it in my mailbox.
>
> I saw the patch but saw nobody else said about the patch being helpful
> to his installation, nor more importantly, "Good, this won't hurt for me
> who run a different vintage of Cygwin", and I was waiting for such
> confirmations.
>
> Then nobody responded, so I forgot.
>
> That was what happened the first time Pascal's patch was posted.

I think the patch is fine; I just checked with my copy of Cygwin that I haven't fired for some time (it was a pain waiting for it to update to the latest set of git sources).

I am at work and will be busy for the rest of the afternoon, so won't be applying it until this evening, though.