Re: [PATCH] Set OLD_ICONV on Cygwin.

From: Andreas Ericsson <ae@op5.se>
Date: Dec 4, 2007, 13:43 UTC
Message-ID: <4755597B.9050709@op5.se>
In-Reply-To: <21977191.137171196775591804.JavaMail.www@wwinf1621>

Pascal Obry wrote:

Show 6 quoted lines

> Andreas Ericsson wrote:
>> Only one, insofar as I can see; You didn't CC Junio. He probably missed it.
> 
> Hum, I don't think this is a requirement. At least nothing is said about
> CCing Junio on the Git Web site.
>

It's not a requirement, but he won't act on things he doesn't see, and CC'ing him directly is the recommended way of getting his attention. Most people do so for patches that aren't directly related to a sub-part of git primarily maintained by someone else (Shawn O. Pearce for git-gui, Eric Wong for git-svn, etc., etc.)

> Anyway, now Junio is CCed :)
>

Nice. If my suspicions are correct and he missed your patch the first time around, you should probably resend it though.

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231